8983 libbe: be_do_installboot() fails with vdev replacing
Review Request #1117 - Created June 19, 2018 and submitted
Information | |
---|---|
Toomas Soome | |
illumos-gate | |
8983 | |
e90780d... | |
Reviewers | |
general | |
8983: libbe: be_do_installboot() fails with vdev replacing
root@uefi-oi:/home/tsoome# beadm activate -v uefi-199 be_do_installboot: child 0 of 1 device mirror-0 be_do_installboot: child 0 of 2 device c3t0d0 Command: "/usr/sbin/installboot -m -f //boot/pmbr //boot/gptzfsboot /dev/rdsk/c3t0d0s1" Errors: bootblock version installed on /dev/rdsk/c3t0d0s1 is more recent or identical Use -F to override or install without the -u option be_do_installboot: child 1 of 2 device replacing-1 be_do_installboot: child 0 of 2 device c6t3d0/old be_do_installboot: vdev /dev/dsk/c6t3d0s1/old is OFFLINE, can't install boot loader be_do_installboot: child 1 of 2 device c6t3d0 Command: "/usr/sbin/installboot -m -f //boot/pmbr //boot/gptzfsboot /dev/rdsk/c6t3d0s1" Errors: bootblock version installed on /dev/rdsk/c6t3d0s1 is more recent or identical Use -F to override or install without the -u option Activated successfully root@uefi-oi:/home/tsoome#From the above, we have mirror with c6t3d0 being replaced, we are recursing into vdev "replacing-1", we are detecting the offline device and ignoring it, and we do have installboot being executed for new device.
Review request changed
Summary: |
|
---|
Ship It!
-
usr/src/lib/libbe/common/be_activate.c (Diff revision 1) -
If these messages are supposed to help with tracing where we failed, shouldn't we print correct function names? i.e. use
"%s:....", __func__, ...
here instead. -
usr/src/lib/libbe/common/be_activate.c (Diff revision 1) -
I understand that we have C99 enabled, but it looks like more of a style issue where we define all variables at the start of function.
-
usr/src/lib/libbe/common/be_activate.c (Diff revision 1) -
Should have a whitespace after
-1
?
Review request changed
Change Summary:
use func as suggested by Yuri.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+108 -113) |
Ship It!
Ship It!
Review request changed
Change Summary:
debug mode build did complain about unused variables.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+109 -117) |
Ship It!