Split the custr functions into their own library

Review Request #1175 — Created Aug. 22, 2018 and submitted

jbk
illumos-gate
9762
general

Using the custr functions currently requires linking against libcmdutils, which itself pulls in a lot of dependent libraries. It would be nicer to split this off into it's own library for future in-gate use (though kept private to illumos-gate for now).

On illumos-gate, the only current consumers are mailx and the libc symbol tests. I created an email (to root) using mailx, then used mailx to read the email (which should exercise the custr functions). I also ran the libc tests on an omnios vm built with the changes (which were successful). As a further sanity check, I ran ldd against the above libraries to verify they were linked against libcustr.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
citrus
  1. LGTM - just the one nit.

  2. usr/src/lib/libcustr/Makefile.com (Diff revision 1)
     
     

    I'm guessing dladm only needs this in SmartOS? Can you find an example applicable to gate or just remove the reference to dladm?

    1. Yeah -- the dladm overlay pieces make use of custr on SmartOS. I'll update the comment.

  3. 
      
jbk
igork
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
yuripv
  1. I wonder if we should document the interface, even if it's private library, it would still be useful to know what it is and how it is used (I wasn't aware that it even exists).

  2. 
      
jbk
Review request changed

Status: Closed (submitted)

Loading...