-
usr/src/cmd/fdisk/fdisk.c (Diff revision 1) -
Why is it returns silently instead of exiting with an error message?
Not for this issue.
Duplicated endian conversion macros.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 1) -
These endian conversion macros aren't needed, instead use
LE_*
macros from<sys/byteorder.h>
(wich is already included). -
usr/src/cmd/fdisk/fdisk.c (Diff revision 1) -
Replace
lel
withLE_32
(+ in the next line). -
usr/src/cmd/fdisk/fdisk.c (Diff revision 1) -
Same (+ next 3 line).
Review request changed
Change Summary:
Change suggested by Gergő Mihály Doma
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+28 -27) |
"Space followed by tab" nits from the past.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Space followed by tab.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same + in the next line: convert 6 space to 1 tab.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Same.
C-style issues.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Missing braces.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Missing braces.
From 'C Style and Coding Standards for SunOS' :In either case, if one arm of an if-else statement contains braces, all arms should contain braces.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Missing braces.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 2) -
Wrong indentation.
Review request changed
Change Summary:
cstyle cleanup
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+47 -45) |
Man page issues.
-
usr/src/man/man1m/fdisk.1m (Diff revision 3) -
The lines of licensing information are too long (it seems like this is true for other man pages too). Exception: "usr/src/man/man1has/ex.1has" contains a better formatted CDDL information. Is it permitted to replace this with that can be found in "/usr/src/prototypes/prototype.man", or it should be preserved as-is (for ex.: with the same dead url)?
-
usr/src/man/man1m/fdisk.1m (Diff revision 3) -
Double space between "an" and "entry".
Review request changed
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+48 -46) |
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 4) -
This is not a fault from fdisk's* point of view.
-
usr/src/cmd/fdisk/fdisk.c (Diff revision 4) -
Missing io_mboot parameter here.
Review request changed
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+48 -46) |
Ship It!