6612 NULL pointer constant issues in uts/common/fs

Review Request #132 - Created Feb. 6, 2016 and updated

Information
Richard PALO
illumos-gate
5218, 6612
269b300...
Reviewers
general
6612 NULL pointer constant issues in uts/common/fs

pre wsdiff is gate at commit bc07d1f with enable_perl64 patch applied

git pbchk: cleaned for cstyle, ignored copyright messages

commit 269b300614926ac100cf8403d5d7d4fc67b08d3c
Author: Richard PALO <richard@NetBSD.org>
Date:   Sat Feb 6 15:48:06 2016 +0100

    6612 NULL pointer constant issues in uts/common/fs

:100644 100644 8d348a3... 86422ed... M  usr/src/uts/common/fs/dev/sdev_ipnetops.c
:100644 100644 4eaf38f... a426eea... M  usr/src/uts/common/fs/dev/sdev_netops.c
:100644 100644 a481164... 07a5001... M  usr/src/uts/common/fs/dev/sdev_profile.c
:100644 100644 af98df7... 4d8f473... M  usr/src/uts/common/fs/dev/sdev_ptsops.c
:100644 100644 e29262d... ea9d96d... M  usr/src/uts/common/fs/dev/sdev_vtops.c
:100644 100644 11384e3... 2769604... M  usr/src/uts/common/fs/dev/sdev_zvolops.c
:100644 100644 25327d2... de719e0... M  usr/src/uts/common/fs/dnlc.c
:100644 100644 6e9456f... be00f9d... M  usr/src/uts/common/fs/hsfs/hsfs_node.c
:100644 100644 9a6d2c3... ab4013e... M  usr/src/uts/common/fs/hsfs/hsfs_rrip.c
:100644 100644 dbe9aa4... 73a0706... M  usr/src/uts/common/fs/hsfs/hsfs_vfsops.c
:100644 100644 13e620d... 6cdc04f... M  usr/src/uts/common/fs/namefs/namevfs.c
:100644 100644 ed2c2c1... 25b82a7... M  usr/src/uts/common/fs/nfs/nfs4_client_secinfo.c
:100644 100644 944df03... 1f4fba3... M  usr/src/uts/common/fs/nfs/nfs_dlinet.c
:100644 100644 b85c6ab... 1978227... M  usr/src/uts/common/fs/pcfs/pc_vfsops.c
:100644 100644 14be8cb... 76484c2... M  usr/src/uts/common/fs/portfs/port.c
:100644 100644 f1f39ed... e840590... M  usr/src/uts/common/fs/proc/prioctl.c
:100644 100644 efc3c37... edf283a... M  usr/src/uts/common/fs/proc/prvfsops.c
:100644 100644 02c6c9a... b686aae... M  usr/src/uts/common/fs/smbclnt/netsmb/smb_dev.c
:100644 100644 75241cc... 9b040cb... M  usr/src/uts/common/fs/smbclnt/smbfs/smbfs_xattr.c
:100644 100644 88584ed... ce3809c... M  usr/src/uts/common/fs/sockfs/nl7c.c
:100755 100755 d3dfe2e... 8bd1161... M  usr/src/uts/common/fs/sockfs/nl7ctokgen
:100644 100644 c6818ba... 65a77b4... M  usr/src/uts/common/fs/sockfs/nl7curi.c
:100644 100644 37e4413... 4732ad1... M  usr/src/uts/common/fs/sockfs/socktpi.c
:100644 100644 a5937de... 6709313... M  usr/src/uts/common/fs/specfs/specsubr.c
:100644 100644 07d303a... b6c8c2c... M  usr/src/uts/common/fs/swapfs/swap_vnops.c
:100644 100644 f8a36a5... 4e2784f... M  usr/src/uts/common/fs/tmpfs/tmp_vfsops.c
:100644 100644 bf845fe... 6a4e670... M  usr/src/uts/common/fs/udfs/udf_subr.c
:100644 100644 93cc4d4... 418284d... M  usr/src/uts/common/fs/udfs/udf_vnops.c
:100644 100644 9476072... 490415c... M  usr/src/uts/common/fs/ufs/ufs_acl.c
:100644 100644 3e4d38a... 9afb12e... M  usr/src/uts/common/fs/ufs/ufs_alloc.c
:100644 100644 4fc77e9... beedb1f... M  usr/src/uts/common/fs/ufs/ufs_dir.c
:100644 100644 e6b6adf... f9261c6... M  usr/src/uts/common/fs/vnode.c
:100644 100644 ee2d8ee... de0f923... M  usr/src/uts/common/fs/zfs/dsl_pool.c
:100644 100644 9030b85... 3783742... M  usr/src/uts/common/fs/zfs/metaslab.c
:100644 100644 7ddf806... fbbaea8... M  usr/src/uts/common/fs/zfs/sa.c
:100644 100644 6f30154... b5598d5... M  usr/src/uts/common/fs/zfs/vdev.c
:100644 100644 f82104e... a8450d9... M  usr/src/uts/common/fs/zfs/zfs_ioctl.c
:100644 100644 9cba49b... 3033dae... M  usr/src/uts/common/fs/zfs/zfs_vnops.c
:100644 100644 590f1df... 0b0d744... M  usr/src/uts/common/fs/zfs/zil.c

wsdiff attached with is now common for il_6609 .. il_6615

ignoring all but 'ELF .text'

richard@omnis:/home/richard/src/illumos-gate$ ggrep -B1 'NOTE: ELF .text' /tmp/wsdiff.log |grep -Ev 'NOTE:|--'
usr/kernel/drv/amd64/ii
usr/lib/amd64/libzpool.so.1
usr/lib/libzpool.so.1
platform/i86pc/kernel/drv/amd64/dr
kernel/misc/amd64/kgssapi
kernel/misc/amd64/dls
kernel/misc/dls
kernel/drv/amd64/softmac
kernel/drv/amd64/qlge
kernel/drv/amd64/llc1
kernel/drv/amd64/zfs
kernel/drv/amd64/mpt_sas
kernel/drv/amd64/dtrace
kernel/drv/softmac
kernel/drv/mpt_sas
kernel/drv/dtrace
kernel/drv/zfs
kernel/fs/amd64/zfs
kernel/fs/zfs
kernel/genunix

all are seemingly equivalent but with line additions/suppressions (cstyle, ctf?)
with the exception of the following x86_64 which seem equivalent as well, but the x86_64
codegeneration, in particular for NOPs, is slightly different, and in most cases more compact:

usr/kernel/drv/amd64/ii
kernel/misc/amd64/kgssapi
kernel/drv/amd64/qlge
kernel/drv/amd64/llc1

I'm running this now (since rebasing with the enable_perl64).

BTW, the collective patchset is also available via https://github.com/risto3/illumos-gate/commits/il_uts-NULL
(for the uts/ part of il_5218, that is: il_6609 .. il_6615)

Files


Issues

  • 1
  • 0
  • 1
  • 2
Description From Last Updated
should this be '\0'? Josef Sipek Josef Sipek
Toomas Soome
Toomas Soome
Richard PALO
Review request changed

Testing Done:

  +

pre wsdiff is gate at commit bc07d1f with enable_perl64 patch applied

  +
  +

git pbchk: cleaned for cstyle, ignored copyright messages

  +
  +

  +
  +
commit 269b300614926ac100cf8403d5d7d4fc67b08d3c
  +
Author: Richard PALO <richard@NetBSD.org>
  +
Date:   Sat Feb 6 15:48:06 2016 +0100
  +
  +
    6612 NULL pointer constant issues in uts/common/fs
  +
  +
:100644 100644 8d348a3... 86422ed... M  usr/src/uts/common/fs/dev/sdev_ipnetops.c
  +
:100644 100644 4eaf38f... a426eea... M  usr/src/uts/common/fs/dev/sdev_netops.c
  +
:100644 100644 a481164... 07a5001... M  usr/src/uts/common/fs/dev/sdev_profile.c
  +
:100644 100644 af98df7... 4d8f473... M  usr/src/uts/common/fs/dev/sdev_ptsops.c
  +
:100644 100644 e29262d... ea9d96d... M  usr/src/uts/common/fs/dev/sdev_vtops.c
  +
:100644 100644 11384e3... 2769604... M  usr/src/uts/common/fs/dev/sdev_zvolops.c
  +
:100644 100644 25327d2... de719e0... M  usr/src/uts/common/fs/dnlc.c
  +
:100644 100644 6e9456f... be00f9d... M  usr/src/uts/common/fs/hsfs/hsfs_node.c
  +
:100644 100644 9a6d2c3... ab4013e... M  usr/src/uts/common/fs/hsfs/hsfs_rrip.c
  +
:100644 100644 dbe9aa4... 73a0706... M  usr/src/uts/common/fs/hsfs/hsfs_vfsops.c
  +
:100644 100644 13e620d... 6cdc04f... M  usr/src/uts/common/fs/namefs/namevfs.c
  +
:100644 100644 ed2c2c1... 25b82a7... M  usr/src/uts/common/fs/nfs/nfs4_client_secinfo.c
  +
:100644 100644 944df03... 1f4fba3... M  usr/src/uts/common/fs/nfs/nfs_dlinet.c
  +
:100644 100644 b85c6ab... 1978227... M  usr/src/uts/common/fs/pcfs/pc_vfsops.c
  +
:100644 100644 14be8cb... 76484c2... M  usr/src/uts/common/fs/portfs/port.c
  +
:100644 100644 f1f39ed... e840590... M  usr/src/uts/common/fs/proc/prioctl.c
  +
:100644 100644 efc3c37... edf283a... M  usr/src/uts/common/fs/proc/prvfsops.c
  +
:100644 100644 02c6c9a... b686aae... M  usr/src/uts/common/fs/smbclnt/netsmb/smb_dev.c
  +
:100644 100644 75241cc... 9b040cb... M  usr/src/uts/common/fs/smbclnt/smbfs/smbfs_xattr.c
  +
:100644 100644 88584ed... ce3809c... M  usr/src/uts/common/fs/sockfs/nl7c.c
  +
:100755 100755 d3dfe2e... 8bd1161... M  usr/src/uts/common/fs/sockfs/nl7ctokgen
  +
:100644 100644 c6818ba... 65a77b4... M  usr/src/uts/common/fs/sockfs/nl7curi.c
  +
:100644 100644 37e4413... 4732ad1... M  usr/src/uts/common/fs/sockfs/socktpi.c
  +
:100644 100644 a5937de... 6709313... M  usr/src/uts/common/fs/specfs/specsubr.c
  +
:100644 100644 07d303a... b6c8c2c... M  usr/src/uts/common/fs/swapfs/swap_vnops.c
  +
:100644 100644 f8a36a5... 4e2784f... M  usr/src/uts/common/fs/tmpfs/tmp_vfsops.c
  +
:100644 100644 bf845fe... 6a4e670... M  usr/src/uts/common/fs/udfs/udf_subr.c
  +
:100644 100644 93cc4d4... 418284d... M  usr/src/uts/common/fs/udfs/udf_vnops.c
  +
:100644 100644 9476072... 490415c... M  usr/src/uts/common/fs/ufs/ufs_acl.c
  +
:100644 100644 3e4d38a... 9afb12e... M  usr/src/uts/common/fs/ufs/ufs_alloc.c
  +
:100644 100644 4fc77e9... beedb1f... M  usr/src/uts/common/fs/ufs/ufs_dir.c
  +
:100644 100644 e6b6adf... f9261c6... M  usr/src/uts/common/fs/vnode.c
  +
:100644 100644 ee2d8ee... de0f923... M  usr/src/uts/common/fs/zfs/dsl_pool.c
  +
:100644 100644 9030b85... 3783742... M  usr/src/uts/common/fs/zfs/metaslab.c
  +
:100644 100644 7ddf806... fbbaea8... M  usr/src/uts/common/fs/zfs/sa.c
  +
:100644 100644 6f30154... b5598d5... M  usr/src/uts/common/fs/zfs/vdev.c
  +
:100644 100644 f82104e... a8450d9... M  usr/src/uts/common/fs/zfs/zfs_ioctl.c
  +
:100644 100644 9cba49b... 3033dae... M  usr/src/uts/common/fs/zfs/zfs_vnops.c
  +
:100644 100644 590f1df... 0b0d744... M  usr/src/uts/common/fs/zfs/zil.c
  +
  +
  +

wsdiff attached with is now common for il_6609 .. il_6615

  +
  +

ignoring all but 'ELF .text'

  +
  +
richard@omnis:/home/richard/src/illumos-gate$ ggrep -B1 'NOTE: ELF .text' /tmp/wsdiff.log |grep -Ev 'NOTE:|--'
  +
usr/kernel/drv/amd64/ii
  +
usr/lib/amd64/libzpool.so.1
  +
usr/lib/libzpool.so.1
  +
platform/i86pc/kernel/drv/amd64/dr
  +
kernel/misc/amd64/kgssapi
  +
kernel/misc/amd64/dls
  +
kernel/misc/dls
  +
kernel/drv/amd64/softmac
  +
kernel/drv/amd64/qlge
  +
kernel/drv/amd64/llc1
  +
kernel/drv/amd64/zfs
  +
kernel/drv/amd64/mpt_sas
  +
kernel/drv/amd64/dtrace
  +
kernel/drv/softmac
  +
kernel/drv/mpt_sas
  +
kernel/drv/dtrace
  +
kernel/drv/zfs
  +
kernel/fs/amd64/zfs
  +
kernel/fs/zfs
  +
kernel/genunix
  +
  +
  +

all are seemingly equivalent but with line additions/suppressions (cstyle, ctf?)

  + with the exception of the following x86_64 which seem equivalent as well, but the x86_64
  + codegeneration, in particular for NOPs, is slightly different, and in most cases more compact:

  +
  +
usr/kernel/drv/amd64/ii
  +
kernel/misc/amd64/kgssapi
  +
kernel/drv/amd64/qlge
  +
kernel/drv/amd64/llc1
  +
  +
  +

I'm running this now (since rebasing with the enable_perl64).

  +
  +

BTW, the collective patchset is also available via https://github.com/risto3/illumos-gate/commits/il_uts-NULL

  + (for the uts/ part of il_5218, that is: il_6609 .. il_6615)

Commit:

-e9bfa93324bea62a7563cc0441a93f9780cdd637
+269b300614926ac100cf8403d5d7d4fc67b08d3c

Diff:

Revision 2 (+206 -218)

Show changes

Added Files:

Josef Sipek

   
usr/src/uts/common/fs/sockfs/nl7c.c (Diff revision 2)
 
 

should this be '\0'?

  1. Otherwise, LGTM.

Ken Mays
Ship It!
Loading...