6613 NULL pointer constant issues in uts/common/os

Review Request #133 - Created Feb. 6, 2016 and updated

Information
Richard PALO
illumos-gate
5218, 6613
26aaca5...
Reviewers
general
6613 NULL pointer constant issues in uts/common/os

pre wsdiff is gate at commit bc07d1f with enable_perl64 patch applied

git pbchk: cleaned for cstyle, ignored copyright messages

richard@omnis:/home/richard/src/illumos-gate$ git whatchanged -1
commit 26aaca5eb552a173a9299eeea7b75de41a906cd7
Author: Richard PALO <richard@NetBSD.org>
Date:   Sat Feb 6 15:57:17 2016 +0100

    6613 NULL pointer constant issues in uts/common/os

:100644 100644 96f51b1... e4032d6... M  usr/src/uts/common/os/aio.c
:100644 100644 b8d2e29... b0c3b65... M  usr/src/uts/common/os/bio.c
:100644 100644 0af67f5... 8b3177b... M  usr/src/uts/common/os/brand.c
:100644 100644 1ab2afa... adabf9a... M  usr/src/uts/common/os/dacf.c
:100644 100644 f90c556... 52fad78... M  usr/src/uts/common/os/damap.c
:100644 100644 38d5f1a... 3f82b02... M  usr/src/uts/common/os/dumpsubr.c
:100644 100644 092dd42... 0bcf125... M  usr/src/uts/common/os/evchannels.c
:100644 100644 172fce8... 616a5df... M  usr/src/uts/common/os/exec.c
:100644 100644 9381019... 7883437... M  usr/src/uts/common/os/ipc.c
:100644 100644 7afc1cf... 0d26b28... M  usr/src/uts/common/os/main.c
:100644 100644 35162eb... 7ce1ed5... M  usr/src/uts/common/os/modctl.c
:100644 100644 a4d66c6... 613e624... M  usr/src/uts/common/os/modsysfile.c
:100644 100644 fbd9a64... 3622241... M  usr/src/uts/common/os/panic.c
:100644 100644 fa6e819... bc7e6e2... M  usr/src/uts/common/os/pcifm.c
:100644 100644 07bc292... 4912e01... M  usr/src/uts/common/os/policy.c
:100644 100644 c79c7da... 6d183cd... M  usr/src/uts/common/os/pool.c
:100644 100644 62f9472... e09e6b9... M  usr/src/uts/common/os/streamio.c
:100644 100644 1c39b5b... 695a9bb... M  usr/src/uts/common/os/strsubr.c
:100644 100644 b26685d... 9af242c... M  usr/src/uts/common/os/sunpci.c
:100644 100644 b25825e... 43787d5... M  usr/src/uts/common/os/task.c
:100644 100644 f11f9cf... d21f23f... M  usr/src/uts/common/os/taskq.c
:100644 100644 c997f8f... 0a727dd... M  usr/src/uts/common/os/zone.c

wsdiff attached with is now common for il_6609 .. il_6615

ignoring all but 'ELF .text'

richard@omnis:/home/richard/src/illumos-gate$ ggrep -B1 'NOTE: ELF .text' /tmp/wsdiff.log |grep -Ev 'NOTE:|--'
usr/kernel/drv/amd64/ii
usr/lib/amd64/libzpool.so.1
usr/lib/libzpool.so.1
platform/i86pc/kernel/drv/amd64/dr
kernel/misc/amd64/kgssapi
kernel/misc/amd64/dls
kernel/misc/dls
kernel/drv/amd64/softmac
kernel/drv/amd64/qlge
kernel/drv/amd64/llc1
kernel/drv/amd64/zfs
kernel/drv/amd64/mpt_sas
kernel/drv/amd64/dtrace
kernel/drv/softmac
kernel/drv/mpt_sas
kernel/drv/dtrace
kernel/drv/zfs
kernel/fs/amd64/zfs
kernel/fs/zfs
kernel/genunix

all are seemingly equivalent but with line additions/suppressions (cstyle, ctf?) with the exception of the following x86_64 which seem equivalent as well, but the x86_64 codegeneration, in particular for NOPs, is slightly different, and in most cases more compact:

usr/kernel/drv/amd64/ii
kernel/misc/amd64/kgssapi
kernel/drv/amd64/qlge
kernel/drv/amd64/llc1

I'm running this now (since rebasing with the enable_perl64).

BTW, the collective patchset is also available via https://github.com/risto3/illumos-gate/commits/il_uts-NULL (for the uts/ part of il_5218, that is: il_6609 .. il_6615)

Files


Richard PALO
Review request changed

Testing Done:

  +

pre wsdiff is gate at commit bc07d1f with enable_perl64 patch applied

  +
  +

git pbchk: cleaned for cstyle, ignored copyright messages

  +
  +

  +
  +
richard@omnis:/home/richard/src/illumos-gate$ git whatchanged -1
  +
commit 26aaca5eb552a173a9299eeea7b75de41a906cd7
  +
Author: Richard PALO <richard@NetBSD.org>
  +
Date:   Sat Feb 6 15:57:17 2016 +0100
  +
  +
    6613 NULL pointer constant issues in uts/common/os
  +
  +
:100644 100644 96f51b1... e4032d6... M  usr/src/uts/common/os/aio.c
  +
:100644 100644 b8d2e29... b0c3b65... M  usr/src/uts/common/os/bio.c
  +
:100644 100644 0af67f5... 8b3177b... M  usr/src/uts/common/os/brand.c
  +
:100644 100644 1ab2afa... adabf9a... M  usr/src/uts/common/os/dacf.c
  +
:100644 100644 f90c556... 52fad78... M  usr/src/uts/common/os/damap.c
  +
:100644 100644 38d5f1a... 3f82b02... M  usr/src/uts/common/os/dumpsubr.c
  +
:100644 100644 092dd42... 0bcf125... M  usr/src/uts/common/os/evchannels.c
  +
:100644 100644 172fce8... 616a5df... M  usr/src/uts/common/os/exec.c
  +
:100644 100644 9381019... 7883437... M  usr/src/uts/common/os/ipc.c
  +
:100644 100644 7afc1cf... 0d26b28... M  usr/src/uts/common/os/main.c
  +
:100644 100644 35162eb... 7ce1ed5... M  usr/src/uts/common/os/modctl.c
  +
:100644 100644 a4d66c6... 613e624... M  usr/src/uts/common/os/modsysfile.c
  +
:100644 100644 fbd9a64... 3622241... M  usr/src/uts/common/os/panic.c
  +
:100644 100644 fa6e819... bc7e6e2... M  usr/src/uts/common/os/pcifm.c
  +
:100644 100644 07bc292... 4912e01... M  usr/src/uts/common/os/policy.c
  +
:100644 100644 c79c7da... 6d183cd... M  usr/src/uts/common/os/pool.c
  +
:100644 100644 62f9472... e09e6b9... M  usr/src/uts/common/os/streamio.c
  +
:100644 100644 1c39b5b... 695a9bb... M  usr/src/uts/common/os/strsubr.c
  +
:100644 100644 b26685d... 9af242c... M  usr/src/uts/common/os/sunpci.c
  +
:100644 100644 b25825e... 43787d5... M  usr/src/uts/common/os/task.c
  +
:100644 100644 f11f9cf... d21f23f... M  usr/src/uts/common/os/taskq.c
  +
:100644 100644 c997f8f... 0a727dd... M  usr/src/uts/common/os/zone.c
  +
  +
  +

  +
  +

wsdiff attached with is now common for il_6609 .. il_6615

  +
  +

ignoring all but 'ELF .text'

  +
  +
richard@omnis:/home/richard/src/illumos-gate$ ggrep -B1 'NOTE: ELF .text' /tmp/wsdiff.log |grep -Ev 'NOTE:|--'
  +
usr/kernel/drv/amd64/ii
  +
usr/lib/amd64/libzpool.so.1
  +
usr/lib/libzpool.so.1
  +
platform/i86pc/kernel/drv/amd64/dr
  +
kernel/misc/amd64/kgssapi
  +
kernel/misc/amd64/dls
  +
kernel/misc/dls
  +
kernel/drv/amd64/softmac
  +
kernel/drv/amd64/qlge
  +
kernel/drv/amd64/llc1
  +
kernel/drv/amd64/zfs
  +
kernel/drv/amd64/mpt_sas
  +
kernel/drv/amd64/dtrace
  +
kernel/drv/softmac
  +
kernel/drv/mpt_sas
  +
kernel/drv/dtrace
  +
kernel/drv/zfs
  +
kernel/fs/amd64/zfs
  +
kernel/fs/zfs
  +
kernel/genunix
  +
  +
  +

  +
  +

all are seemingly equivalent but with line additions/suppressions (cstyle, ctf?) with the exception of the following x86_64 which seem equivalent as well, but the x86_64 codegeneration, in particular for NOPs, is slightly different, and in most cases more compact:

  +
  +
usr/kernel/drv/amd64/ii
  +
kernel/misc/amd64/kgssapi
  +
kernel/drv/amd64/qlge
  +
kernel/drv/amd64/llc1
  +
  +
  +

  +
  +

I'm running this now (since rebasing with the enable_perl64).

  +
  +

BTW, the collective patchset is also available via https://github.com/risto3/illumos-gate/commits/il_uts-NULL (for the uts/ part of il_5218, that is: il_6609 .. il_6615)

Commit:

-87ca54f4bdcf87fda40477a8d35c448aed13f937
+26aaca5eb552a173a9299eeea7b75de41a906cd7

Diff:

Revision 2 (+66 -64)

Show changes

Added Files:

Josef Sipek

   
usr/src/uts/common/os/bio.c (Diff revision 2)
 
 

In general, I like using ASSERT0(x) instead of ASSERT(x == 0) because it tells me what the actual value was. In this case, it's pretty obvious that the B_NOCACHE flag was set.

Josef Sipek
Ship It!
Ken Mays
Ship It!
Loading...