10163 ufs_fsck: bitwise comparison always evaluates to false

Review Request #1333 - Created Dec. 25, 2018 and updated

Information
Toomas Soome
illumos-gate
10163
7214b03...
Reviewers
general
pass2.c: In function 'pass2':
pass2.c:243:42: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
   if ((statemap[inp->i_number] & STMASK) == DCLEAR ||
                                          ^~
cc1: all warnings being treated as errors

  

Issues

  • 1
  • 3
  • 0
  • 4
Description From Last Updated
How did you decide to also check for INCLEAR here as opposed to changing the right hand side to only ... Robert Mustacchi Robert Mustacchi
Gergő Mihály Doma
Toomas Soome
Review request changed

Change Summary:

cstyle cleanup

Commit:

-700482138822713a13b41110735c1f6dfd28057a
+7214b03aa07237ce0dd5894b79534de86aca20d9

Diff:

Revision 2 (+35 -34)

Show changes

Robert Mustacchi

   
usr/src/cmd/fs.d/ufs/fsck/pass2.c (Diff revision 2)
 
 
How did you decide to also check for INCLEAR here as opposed to changing the right hand side to only be DSTATE?
Loading...