id variable type is uint64_t, so please use the corresponding format macro constant from <inttypes.h>.

usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 1)

Show all issues

This line should be:
asprintf(&name, "%s%d-%" PRIu64, type,

usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 1)

Show all issues

asprintf(&name, "%s-%" PRIu64, type, id);

usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 2)

Show all issues

That's not a good assumption to make in general (it could be GB's in some cases).  It looks like you've handled the malloc() error below; is there any way to provide a more specific error message to the user?

1. 

   Toomas Soome Jan. 4, 2019, 2:23 p.m.

   Yep, I did add printf to notify the user. And yes, I did read the comment about size - unfortunately we can not really handle gigabytes during the boot.

This looks good to me, I just saw a couple of small things.

usr/src/boot/lib/libstand/zfs/zfsimpl.c (Diff revision 4)

Show all issues

This sentence is incomplete. Should it say "We don't do this for...", or should it say something else?

1. 

   Toomas Soome Aug. 9, 2019, 9:38 p.m.

   Actually it is literal copy from vdev_indirect.c. This sentence is complementing previous one, I do agree it feels badly worded, but I'm not sure what is the best way there. Fix should land on both instances:)

usr/src/boot/lib/libstand/zfs/zfsimpl.c (Diff revision 4)

Show all issues

Should this code check the io_error that can be set in vdev_indirect_gather_splits?

Ship It!