10178 Enable compiler warnings when building C++ code

Review Request #1342 — Created Jan. 5, 2019 and submitted

andy_js
illumos-gate
10178
general

We pass -xne to turn warnings into errors but never actually turn on more than the default set of warnings, which are extremely permissive. For consistency's sake we should be turning on he same warnings that we enable when building C code.

Tested build.

  • 0
  • 0
  • 3
  • 1
  • 4
Description From Last Updated
andy_js
richlowe
  1. 
      
  2. usr/src/Makefile.master (Diff revision 2)
     
     

    Are these definitely valid for studio CC(1)? it's needlessly different in so many other respects...

    1. Im not 100% sure, but I did see them listed on the documentation I found on Oracles's site.

  3. 
      
richlowe
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
andy_js
mscheler
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
tsoome
  1. 
      
  2. usr/src/cmd/audio/audioconvert/Makefile (Diff revision 3)
     
     

    red ugliness

  3. usr/src/cmd/make/lib/mksh/dosys.cc (Diff revision 3)
     
     

    red ugliness

  4. usr/src/lib/libfru/Makefile.flag (Diff revision 3)
     
     

    red ugliness

  5. 
      
andy_js
tsoome
  1. Ship It!
  2. 
      
mscheler
  1. Ship It!
  2. 
      
andy_js
Review request changed

Status: Closed (submitted)

Loading...