Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #1368 -
Created Jan. 14, 2019 and submitted
Jan. 25, 2019, 2:20 a.m.
10236 uts: tem get colors from early boot data
Can we have a comment about the use of the conditional compilation?
Add comment about _HAVE_TEM_FIRMWARE
Revision 2 (+38 -25)
Reading this makes me feel like this is supposed to be a property of SPARC and not a property of whether or not we have TEM firmware. If another platform had TEM firmware, would we not want them to have this?
You mean, we should instead use #ifdef _x86 ? To he honest, I did use _HAVE_TEM_FIRMWARE because other console code used it too and it virtually is alias for sparc anyhow.
I was just trying to understand if this was a property of not having TEM Firmware or not. It seems like on all platforms where we don't have firmware that drives TEM, then we'll want this, is that right?
Right now it really is about if we do have this function implemented or not. Even on SPARC, to read the prom, we would need C wrappers. If the function is missing, we will fall back to using default built in colors anyhow.
I was asking originally to get a better sense of what the appropriate ifdef was and what it was indemic to. For now, we can just let it go as is and deal with it if we have other platforms to worry about. Fundamentally what I was trying to understand was if something else had TEM firmware, would it make sense for that to not implement it, because it's being taken care of by the firmware or we have a common implementation.