Build on sparc calls assembler incorrectly

Review Request #1376 - Created Jan. 17, 2019 and submitted

Information
Peter Tribble
illumos-gate
10257
Reviewers
general
Building on sparc fails with many of the following in libbc:

/usr/ccs/bin/as -xregsym=no -P -D__STDC__ -DLOCORE -D_SYS_SYS_S -D_ASM -Dsparc
-I. -Iinc -I../inc/include -I../inc/include/sys -DTEXT_DOMAIN=\"SUNW_OST_OSLIB\"
-D_TS_ERRNO -I/export/home/ptribble/Illumos/test1-gate/proto/root_sparc/usr/include -fpic -DPIC -K pic -DPIC ../libc/crt/sparc/misalign.s -o pics/misalign.o
/usr/ccs/bin/as: error: unknown option 'f'
/usr/ccs/bin/as: error: unknown option 'p'

Looking at the Makefile, CPPFLAGS is augmented to contain -fpic via C_PICFLAGS, which is then copied to ASFLAGS. So simply copy the original CPPFLAGS into ASFLAGS, so it can't get modified wrongly later.

With the fix, build on sparc no longer has the error.

I can also verify, as of revision 2, that the actual flags passed to as are the same as they were before the change that broke this. (I have an old nightly.log for comparison.)

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
John Levon
Peter Tribble
Peter Tribble
John Levon
Gergő Mihály Doma
Andrew Stormont
Peter Tribble
Review request changed

Status: Closed (submitted)

Loading...