10331 uts: gfx_private bitmap framebuffer implementation

Review Request #1417 — Created Feb. 1, 2019 and submitted

tsoome
illumos-gate
10331
1421
8e9c37c...
general
uts: gfx_private implement cls callback & visual_io v4
uts: gfx_private add alpha blending
uts: provide fb_info via fbgattr dev_specific array.
uts: identify FB types and set up gfx_private based on type.
uts: gfx_private should use setmode drm callback.

apply https://www.illumos.org/rb/r/1356/ and boot. Note that alpha blend needs update in tem to make text to appear on screen with 32-bit depth.

  • 0
  • 0
  • 14
  • 0
  • 14
Description From Last Updated
tsoome
jlevon
  1. 
      
  2. nit: "simplified" (but if it's going to be removed later, no big deal)

    1. Removed. it still is simple, however:)

  3. Both args are used

  4. (optional) replace with __unused?

  5. this comment seems wrong?

    1. not entirely - I meant the fb content is in shadow_fb.

  6. nit missing space after cast

  7. nit missing space after cast

  8. odd formatting?

  9. Nit: you should use this consistently (e.g. :1073) if you're going to have it

  10. Why is this still here?

  11. These get cleaned up later?

    1. Removed. I kept this stuff around for just a case, we probably should eventually remove it all unless someone wants to implement vga gfx mode.

  12. 
      
tsoome
jlevon
  1. 
      
  2. usr/src/uts/i86pc/io/gfx_private/gfxp_bitmap.c (Diff revisions 1 - 2)
     
     

    Actually (sorry) it makes me wonder why these routines pass in the cmd anyway? It's always attach or detach at this point?

    1. hm, yep, thats rigth.

  3. 
      
tsoome
jlevon
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. 
      
  2. For outputting to error, "Cannot" might be preferable as the common form versus "Can not" -- though I also see below "can't" used with cmn_err().

    1. This code has been travelling from vgatext to gfxp_vgatext to there:)

  3. 
      
tsoome
seeemef@mac.com
  1. LGTM

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...