10338 ficl-sys: add gfx primitives

Review Request #1421 — Created Feb. 2, 2019 and submitted

tsoome
illumos-gate
10338
1417
76661a1...
general
10338 ficl-sys: add gfx primitives


  • 0
  • 0
  • 3
  • 1
  • 4
Description From Last Updated
seeemef@mac.com
  1. 
      
  2. usr/src/common/ficl/emu/gfx_fb.h (Diff revision 1)
     
     

    Are you the contributor?

  3. usr/src/common/ficl/emu/gfx_fb.c (Diff revision 1)
     
     

    The comma splicing is slightly difficult to read.

  4. usr/src/common/ficl/emu/gfx_fb.c (Diff revision 1)
     
     

    I wasn't sure if cstyle prefers braces on both if braces on either of if-else.

  5. usr/src/common/ficl/emu/gfx_fb.c (Diff revision 1)
     
     

    spacing around operators here?

  6. usr/src/common/ficl/emu/gfx_fb.c (Diff revision 1)
     
     

    spacing around operators here?

  7. usr/src/common/ficl/emu/gfx_fb.c (Diff revision 1)
     
     

    spacing around operators here?

  8. usr/src/common/ficl/emu/gfx_fb.c (Diff revision 1)
     
     

    spacing around operators here?

  9. usr/src/common/ficl/emu/gfx_fb.c (Diff revision 1)
     
     

    spacing around operators here?

  10. 
      
tsoome
seeemef@mac.com
  1. Ship It!
  2. 
      
citrus
  1. 
      
  2. usr/src/common/ficl/loader.c (Diff revision 2)
     
     

    This block of lines is duplicated..

    1. oops, bad merge/rebase, thanks.

  3. 
      
tsoome
citrus
  1. Ship It!
  2. 
      
jlevon
  1. 
      
  2. usr/src/common/ficl/emu/loader_emu.c (Diff revision 3)
     
     

    You also implement list?

  3. usr/src/common/ficl/emu/loader_emu.c (Diff revision 3)
     
     

    Is there any reason not return an error for unhandled arguments or wrong number?

    1. We do not want to error out from "framebuffer set" because it will abort the interpreting. For example, I usually do framebuffer set 1440x900 in my VM's (as VM's do not provide EDID) and having to comment/uncomment the command would be quite annoying.

    2. I'm not following: seems fine to silently ignore the command failing but shouldn't we still be parsing it? that is, it should complain about "framebuffer set" or "framebuffer spet" shouldn't it?

    3. ah, ok, I see, yes, that would be reasonable indeed. I'll update.

  4. 
      
tsoome
seeemef@mac.com
  1. Ship It!
  2. 
      
tsoome
jlevon
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...