10341 uts: boot_fb_eraseline_impl() may use uninitialized variable

Review Request #1425 — Created Feb. 3, 2019 and submitted

tsoome
illumos-gate
10341
1128670...
general
../../i86pc/boot/boot_fb.c:503:9: error: 'sdst' may be used uninitialized in this function [-Werror=maybe-uninitialized]


  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
andy_js
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. 
      
  2. usr/src/uts/i86pc/boot/boot_fb.c (Diff revision 1)
     
     

    Should perhaps sdst be excised, and the arithmetic be moved to line 502 (inside the other if (fb_info.shadow_fb != NULL) block)?

    1. Nop, I do not like to set it in the loop - I did add "dst" and "sdst" as alias for base [shadow] FB pointer we can use in loop. Also there is nothing wrong in current sdst assignment, except that we need to be careful not to dereference sdst while shadow is not set (that is, during dboot).

  3. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...