10456 libstand: arp.c cstyle cleanup

Review Request #1520 — Created Feb. 26, 2019 and submitted

tsoome
illumos-gate
10456
1517
dae601b...
general
10456 libstand: arp.c cstyle cleanup


seeemef@mac.com
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
domag02
  1. I've found some other (maybe unrelated?) issues, otherwise LGTM.
    1. fixing u_int16_t now, rest is outside the scope.

  2. usr/src/boot/lib/libstand/arp.c (Diff revision 1)
     
     

    Typo.

    's/cacheing/caching/'
    
  3. usr/src/boot/lib/libstand/arp.c (Diff revision 1)
     
     

    Just like in the case of u_char to uchar_t conversion:

    's/u_int16_t/uint16_t/g'
    
  4. usr/src/boot/lib/libstand/arp.c (Diff revision 1)
     
     

    Type of n is ssize_t.

                printf("bad len=%zd\n", n);
    
  5. usr/src/boot/lib/libstand/arp.c (Diff revision 1)
     
     

    Should be:

                printf("not arp type=%u\n", etype);
    

    or

                printf("not arp type=%hu\n", etype);
    
  6. 
      
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...