10714 usbser: NULL pointer errors

Review Request #1680 — Created April 10, 2019 and submitted

tsoome
illumos-gate
10714
ad760af...
general
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/usb/clients/usbser/usbser.c:33:
../../common/io/usb/clients/usbser/usbser.c: In function 'usbser_create_port_minor_nodes':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/usb/clients/usbser/usbser.c:904:37: note: in expansion of macro 'NULL'
      S_IFCHR, minor, DDI_NT_SERIAL, NULL) != DDI_SUCCESS) {
                                     ^~~~
In file included from ../../common/io/usb/clients/usbser/usbser.c:42:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/usb/clients/usbser/usbser.c:33:
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/usb/clients/usbser/usbser.c:916:40: note: in expansion of macro 'NULL'
      S_IFCHR, minor, DDI_NT_SERIAL_DO, NULL) != DDI_SUCCESS) {
                                        ^~~~
In file included from ../../common/io/usb/clients/usbser/usbser.c:42:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


wiedi
  1. Ship It!
  2. 
      
marcel
  1. Ship It!
  2. 
      
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...