5773 Extra pointless steps in kernel module builds

Review Request #18 — Created March 29, 2015 and submitted May 4, 2015, 4:54 p.m.

Information
Owner:	gdamore
Repository:	illumos-gate
Branch:	master
Bugs:
Depends On:
Commit:	0eb29fe...
Reviewers
Groups:	general
People:

Description

5773 Extra pointless steps in kernel module builds

Testing Done

I've been using this in illumos-core for some time now. At one point I measured for my setup an improvment of about 20 minutes in the build time (out of a 2 hour build.) I think this was an excessive result -- I doubt most people will see a lot here, but hey, every little bit helps.

I also cleaned up a couple of CTF-related build scripts (including one in perl) that is now no longer needed.

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
This seems fine, but unrelated to the current set of CTF changes. Can you please make sure another bug is ...	rm	March 31, 2015, 3 p.m.

Ship it!

Make sure you get an additional reviewer who has experience with genunix global-linking type stuff.

usr/src/uts/Makefile.uts (Diff revision 1)
```
Is that trailing white space?
```
1. gdamore April 6, 2015, 5:10 p.m.
  Yes, it was, and I've removed it.

Ship it!

This looks right to me, you could double check the CTF stuff is ok with ctfdump of genunix and a driver to double check that all worked out properly. Uniquification happening is (currently) unfortunately critical until I can get some other stuff fixed, so make absolutely sure it has happened (ctf containers have a parent set, that parent is genunix, other modules such as nfs don't contain a definition of cred_t).

gdamore April 6, 2015, 5:16 p.m.

Verified.
For example, for /kernel/drv/amd64/afe:

CTF Header -----------------------------------------------------------------

cth_magic    = 0xcff1

  cth_version  = 2

  cth_flags    = 0x01

  cth_parlabel = illumos-gate

  cth_parname  = genunix

  cth_lbloff   = 0

  cth_objtoff  = 8

  cth_funcoff  = 36

  cth_typeoff  = 468

  cth_stroff   = 3492

  cth_strlen   = 5373
And I checked nfs doesn't have a cred_t.

Ship it!

All in all, it looks like this is correctly ripping out everything while leaving the general uniquification in place.

usr/src/uts/Makefile.uts (Diff revision 1)

Show all issues

This seems fine, but unrelated to the current set of CTF changes. Can you please make sure another bug is opened to cover this.

gdamore March 31, 2015, 2:57 p.m.

I certainly can do that, although I had covered both the CTF and THIS_YEAR changes in the original bug report for 5773. They are both kind of cleanups of unnecessary steps, so I thought this was sufficient to relate them together.

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

5773 Extra pointless steps in kernel module builds

Status: Closed (submitted)