11213 tem: partially support CSI [ 38 and 48 sequences with smaller depths

Review Request #1981 — Created June 7, 2019 and submitted

tsoome
illumos-gate
11213
b720a25...
general
11213 tem: partially support CSI [ 38 and 48 sequences with smaller depths


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
seeemef@mac.com
  1. 
      
  2. usr/src/uts/common/io/tem_safe.c (Diff revision 1)
     
     

    May I ask the motivation for bool [tem_select_color()] v boolean_t (here)?

    1. The loader tem is using (mostly) stdbool.h - the transition is not yet complete. The kernel tem is built with boolean_t, I think we could switch it to bool as there should not be any external dependencies, but it has not been high priority. I know it is a bit of mess...

  3. 
      
seeemef@mac.com
  1. 
      
  2. usr/src/boot/sys/boot/common/tem.c (Diff revision 1)
     
     

    Is the depth comparison superfluous (w.r.t. line 1189)?

  3. 
      
tsoome
seeemef@mac.com
  1. LGTM

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...