11640 add zpool ashift property tunable Portions contributed by: Richard Laager <rlaager@wiktel.com> Portions contributed by: Christian Kohlschutter <christian@kohlschutter.com> Portions contributed by: Cyril Plisko <cyril.plisko@mountall.

Review Request #2272 — Created Aug. 29, 2019 and submitted Sept. 6, 2019, 3:25 p.m.

Information
Owner:	kkantor
Repository:	illumos-gate
Branch:	reviewboard
Bugs:
Depends On:
Commit:	01946e2...
Reviewers
Groups:	general
People:

Description

11640 add zpool ashift property tunable

Portions contributed by: Richard Laager <rlaager@wiktel.com>

Portions contributed by: Christian Kohlschutter <christian@kohlschutter.com>

Portions contributed by: Cyril Plisko <cyril.plisko@mountall.com>

Portions contributed by: Brian Behlendorf <behlendorf1@llnl.gov>

Portions contributed by: Martin Matuska <martin@matuska.org>

Portions contributed by: Kody Kantor <kody.kantor@joyent.com>

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>

Reviewed by: Giuseppe Di Natale <dinatale2@llnl.gov>
See ticket for porting notes, including the original commit hashes.

Testing Done

ZFS test suite. Failures:

$ grep 'FAIL' /var/tmp/test_results/20190827T195336/log

Test: /opt/zfs-tests/tests/functional/cli_root/zfs_mount/zfs_mount_encrypted (run as root) [00:02] [FAIL]

Test: /opt/zfs-tests/tests/functional/cli_root/zpool_import/zpool_import_missing_003_pos (run as root) [03:16] [FAIL]

Test: /opt/zfs-tests/tests/functional/mmp/mmp_on_zdb (run as root) [00:23] [FAIL]

Test: /opt/zfs-tests/tests/functional/projectquota/projectspace_004_pos (run as root) [00:00] [FAIL]

Test: /opt/zfs-tests/tests/functional/scrub_mirror/setup (run as root) [00:00] [FAIL]

Test: /opt/zfs-tests/tests/functional/write_dirs/setup (run as root) [00:00] [FAIL]
These all appear unrelated to this suggested change.

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
Should perhaps "ashift" (here and line 958) be put on a macro line with .Cm or .Sy?	seeemef@mac.com	Aug. 30, 2019, 4:46 p.m.

Change Summary:

Fixed a couple nits

Commit:

-	97c6e8e37a94d597b300fba8f5ee53be34a0fdee
+	3e90431fc1f4bc757ecfbb1ba470bcd85497f84f

Diff:

Revision 2 (+1021 -53)

Show changes

	usr/src/cmd/fm/modules/common/zfs-retire/zfs_retire.c
	usr/src/cmd/zpool/Makefile
	usr/src/cmd/zpool/zpool_main.c
	usr/src/cmd/zpool/zpool_util.h
	usr/src/cmd/zpool/zpool_vdev.c
	usr/src/common/zfs/zpool_prop.c
	usr/src/lib/libzfs/common/libzfs_pool.c
	usr/src/man/man1m/zpool.1m
	19 more

Description:

		11640 add zpool ashift property tunable
		Portions contributed by: Richard Laager <rlaager@wiktel.com>
		Portions contributed by: Christian Kohlschutter <christian@kohlschutter.com>
		Portions contributed by: Cyril Plisko <cyril.plisko@mountall.com>
		Portions contributed by: Brian Behlendorf <behlendorf1@llnl.gov>
		Portions contributed by: Martin Matuska <martin@matuska.org>
		Portions contributed by: Kody Kantor <kody.kantor@joyent.com>
		Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
		Reviewed by: Giuseppe Di Natale <dinatale2@llnl.gov>

~		See ticket for porting notes.
	~	See ticket for porting notes, including the original commit hashes.

Ship it!

```
This looks good to me, thanks!
```

Ship it!

```
Ship It!
```

usr/src/man/man1m/zpool.1m (Diff revision 2)

Show all issues

Should perhaps "ashift" (here and line 958) be put on a macro line with .Cm or .Sy?

kkantor Aug. 30, 2019, 4:46 p.m.

Good idea. Although .Cm seems like a better choice I used .Sy since that's what seems to be used in this type of situation elsewhere in the file (notably the Properties section).