11675 NFSv4 client: Exclusive create should close the file after setattr failure
Review Request #2300 — Created Sept. 13, 2019 and submitted
| Information | |
|---|---|
| marcel | |
| illumos-gate | |
| master | |
| 11675 | |
| b29f647... | |
| Reviewers | |
| general | |
This adds missing file close into exclusive file create in NFSv4 client in a case the NFS client failed to set file attributes.
I instrumented the NFsv4 client code to add delays to enlarge the race window so I'm able to reproduce the problem reliably. With the fix there are no more files with strange timestamps nor files named .nfsXXXX left at the server when the exclusive create fails to set file attributes.
Status: Closed (submitted)
Change Summary:
commit 20f5f9633a7f7a00734c4c03c7c12016e6935b05
Author: Marcel Telka <marcel@telka.sk>
AuthorDate: Fri Sep 13 07:37:39 2019 +0200
Commit: Dan McDonald <danmcd@joyent.com>
CommitDate: Mon Sep 23 14:10:00 2019 -0400
11675 NFSv4 client: Exclusive create should close the file after setattr failure
Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
Reviewed by: Rich Lowe <richlowe@richlowe.net>
Reviewed by: Jan Schlien <illumos-bugs@jan-o-sch.net>
Approved by: Dan McDonald <danmcd@joyent.com>
:100644 100644 4112cbee05 9f4099c3f8 M usr/src/uts/common/fs/nfs/nfs4_vnops.c