crypto tests need to run 32-bit and 64-bit

Review Request #2310 — Created Sept. 17, 2019 and submitted

jbk
illumos-gate
11706
general

Today the crypto-tests are only being built to execute in a 32-bit fashion. This isn't good. We should make sure both the 32-bit and 64-bit implementations are exercised, especially as they are often very different on the different architectures. Also, the way that the directory structures for the digest tests and for the aes tests are down are opposite one another. This makes them uniform.
Note, this does not attempt to refactor things such that we can test multiple hardware capabilities at a given time.



  • 1
  • 0
  • 1
  • 0
  • 2
Description From Last Updated
is this just due to pkgfmt? jlevon jlevon
jlevon
  1. 
      
  2. is this just due to pkgfmt?

    1. No -- it was just something that didn't get caught in the original review (since it's not in the SmartOS manifests, it wasn't obvious the order flipped). I'd like to defer fixing that until after I've brought illumos-gate in sync w/ illumos-joyent if I can (and can file a ticket once this is integrated to follow up on it) -- it'll simplify things quite a bit for the remaining things in queue to upstream (and Jerry's sanity during the merges).

  3. Typo here, but please just remove lint stuff while you're here.

  4. 
      
jbk
tsoome
  1. Ship It!
  2. 
      
jlevon
  1. Ship It!
  2. 
      
jbk
Review request changed

Status: Closed (submitted)

Loading...