11813 Build /etc/versions/build from fragments

Review Request #2393 — Created Oct. 14, 2019 and updated

citrus
illumos-gate
master
11813
b654108...
general
11813 Build /etc/versions/build from fragments


  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
citrus
jlevon
  1. 
      
  2. usr/src/cmd/boot/bootadm/bootadm.c (Diff revision 2)
     
     

    Nit: should this be SELF_ASSEMBLY_SYSTEM now?

    1. Yes, good idea, changed.

  3. usr/src/cmd/boot/bootadm/bootadm.c (Diff revision 2)
     
     

    "chown" not "chgrp" ?

  4. usr/src/pkg/manifests/SUNWcs.mf (Diff revision 2)
     
     

    I'm not clear on why this change?

    1. I thought about just not delivering /etc/versions/build at all and just relying on /etc/versions/build.illumos-gate and for bootadm to create build, but I thought that might affect distributions like SmartOS. The preserve is there because we don't want pkg verify to fail just because the build file has been updated with additional fragments. This will mean that, assuming it has changed, the file is not updated on subsequent package updates, but bootadm will take care of that during the next reboot. In the meantime, the build file would properly reflect the running system FWIW.

  5. 
      
citrus
Review request changed
jlevon
  1. Ship It!
  2. 
      
Loading...