11930 loader: factor out label and uberblock load from vdev_probe, add MMP checks
Review Request #2439 - Created Nov. 5, 2019 and submitted
| Information | |
|---|---|
| Toomas Soome | |
| illumos-gate | |
| 11930 | |
| 2440 | |
| 399758a... | |
| Reviewers | |
| general | |
11930 loader: factor out label and uberblock load from vdev_probe, add MMP checks
C Fraire
Review request changed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+260 -95) |
-
usr/src/boot/lib/libstand/zfs/zfsimpl.c (Diff revision 2) -
Should
labelcertainly get afree()before every otherreturntoo? -
usr/src/boot/lib/libstand/zfs/zfsimpl.c (Diff revision 2) -
sizeofstyle? (Since this is the first non-declaration, would a zero initialization,= {0}, above forvtmpbe more terse?)
Review request changed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+259 -95) |
LGTM
Review request changed
Change Summary:
going back to memset because with complex structures, the static initializer is getting messy:
/code/11930/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1685: warning: missing braces around initializer [-Wmissing-braces] /code/11930/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1685: warning: (near initialization for 'vtmp.v_childlink') [-Wmissing-braces] /code/11930/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1685: warning: missing braces around initializer [-Wmissing-braces] /code/11930/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1685: warning: (near initialization for 'vtmp.v_childlink') [-Wmissing-braces]
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+260 -95) |
Ship It!