- Download Diff

Summary:

11930 loader: factor out label and uberblock load from vdev_probe, add MMP checks

Review Request #2439 — Created Nov. 5, 2019 and submitted Nov. 12, 2019, 3:25 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	11930
Depends On:
Blocks:	2440
Commit:	399758a...
Reviewers
Groups:	general
People:

Description

11930 loader: factor out label and uberblock load from vdev_probe, add MMP checks

Testing Done

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
Should label certainly get a free() before every other return too?	seeemef@mac.com	Nov. 10, 2019, 2:59 p.m.
sizeof style? (Since this is the first non-declaration, would a zero initialization, = {0}, above for vtmp be more terse?)	seeemef@mac.com	Nov. 10, 2019, 2:59 p.m.

Commit:

-	ea6a1b8baad35d4414481db8fc63493b89085997
+	94b9e3067c276d186d82ad41cc32b10de2e87ee2

Diff:

Revision 2 (+260 -95)

Show changes

	usr/src/boot/Makefile.version
	usr/src/boot/lib/libstand/zfs/zfsimpl.c
	usr/src/boot/sys/cddl/boot/zfs/zfsimpl.h

usr/src/boot/lib/libstand/zfs/zfsimpl.c (Diff revision 2)

Show all issues

Should label certainly get a free() before every other return too?

usr/src/boot/lib/libstand/zfs/zfsimpl.c (Diff revision 2)

Show all issues

sizeof style? (Since this is the first non-declaration, would a zero initialization, = {0}, above for vtmp be more terse?)

Commit:

-	94b9e3067c276d186d82ad41cc32b10de2e87ee2
+	5756b541d077b0fe8c729fc6fbc50b232dc0a288

Diff:

Revision 3 (+259 -95)

Show changes

	usr/src/boot/Makefile.version
	usr/src/boot/lib/libstand/zfs/zfsimpl.c
	usr/src/boot/sys/cddl/boot/zfs/zfsimpl.h

Ship it!

```
LGTM
```

Change Summary:

going back to memset because with complex structures, the static initializer is getting messy:
/code/11930/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1685: warning: missing braces around initializer [-Wmissing-braces]
/code/11930/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1685: warning: (near initialization for 'vtmp.v_childlink') [-Wmissing-braces]
/code/11930/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1685: warning: missing braces around initializer [-Wmissing-braces]
/code/11930/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1685: warning: (near initialization for 'vtmp.v_childlink') [-Wmissing-braces]

Commit:

-	5756b541d077b0fe8c729fc6fbc50b232dc0a288
+	399758ae20a2db843284d45451f8b1a165e0535a

Diff:

Revision 4 (+260 -95)

Show changes

	usr/src/boot/Makefile.version
	usr/src/boot/lib/libstand/zfs/zfsimpl.c
	usr/src/boot/sys/cddl/boot/zfs/zfsimpl.h

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

11930 loader: factor out label and uberblock load from vdev_probe, add MMP checks

Commit:

Diff:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)