smatch sometimes flags problems with ipmp_snap_take()

Review Request #2448 — Created Nov. 9, 2019 and submitted

jbk
illumos-gate
11951
general

Sometimes smatch complains about a double free of 'snap' in ipmp_snap_take()

Built with fix. Built with unrelated code changes (#11946) that were also able to reliably trigger smatch warnings.

jbk
andy_js
  1. Ship It!
  2. 
      
jlevon
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
jbk
tsoome
  1. Yea, I like this one better:)

  2. 
      
citrus
  1. Yes, they look like a false positives to me.
    Is it worth opening an issue for this against smatch?

    1. I've filed #11951 for the smatch issue itself.

  2. 
      
jlevon
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
jbk
Review request changed

Status: Closed (submitted)

Loading...