zfs '::abuf_find' dcmd is broken

Review Request #2509 — Created Jan. 31, 2020 and submitted

jbk
illumos-gate
12267
general

The dcmd no longer works with changes that have occured to the ARC

Found an arc_buf_hdr_t, then used ::abuf_find DVA with it's DVA to verify the dcmd returned the same address.

kkantor
  1. 
      
  2. It looks like there are two other possible states now - ARC_l2c_only and ARC_anon. I'm not sure if these are relevant for users though.

    1. The comments say that things in ARC_anon are not associated with a DVA -- so I think that can safely be ignored (since this dcmds is searching by DVA). For ARC_l2c_anon it suggests that entries there might also appear in the other states (so there might be duplicates), and are only present to assist with lookups (paraphrasing), so I don't think we want that one either, though I'm only about 80% sure on that.

  3. 
      
jjelinek
  1. Ship It!
  2. 
      
igork
  1. Ship It!
  2. 
      
jbk
Review request changed

Status: Closed (submitted)

Loading...