Marcel Telka
Review request changed
Change Summary:
cstyle cleanup. Note we can not get full cstyle cleanup in wrefresh.c without refactoring some code, the blocks are going too steep.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+745 -105) |
-
usr/src/lib/libcurses/screen/termcap.c (Diff revision 1) -
This file should not be here.
Review request changed
Change Summary:
termcap.c is generated file, removing from the update.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+115 -110) |
Ship It!
-
usr/src/lib/libcurses/screen/termcap.ed (Diff revision 3) -
I would instead remove this line and unindent the while compound.
-
usr/src/lib/libcurses/screen/tparm.c (Diff revision 3) -
onrow is not referenced in a case setjmp() returns nonzero. Seems like a compiler bug.
-
usr/src/lib/libcurses/screen/wnoutref.c (Diff revision 3) -
s/lo+1/lo + 1/ ?
Is there anything in these changes that would affect functionality?
If not, I'd just turn off the error. This is legacy code...
Review request changed
Change Summary:
Few simple suggestions from Marcel.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+123 -118) |
Ship It!