- Download Diff

Summary:

7875 libcurses: multiple misleading-indentation errors

Review Request #363 — Created Feb. 15, 2017 and submitted July 31, 2017, 6:51 a.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	7875
Depends On:
Commit:	2d1b49e...
Reviewers
Groups:	general
People:

Description

7875 libcurses: multiple misleading-indentation errors

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
This file should not be here.	marcel	Feb. 15, 2017, 7:31 p.m.

Change Summary:

cstyle cleanup. Note we can not get full cstyle cleanup in wrefresh.c without refactoring some code, the blocks are going too steep.

Commit:

-	ab9e366e8fcb133737c4f41f5c5d193e8d679848
+	82218a7895f836c7d9b02e78affc5b01640d8ebb

Diff:

Revision 2 (+745 -105)

Show changes

	usr/src/lib/libcurses/screen/termcap.c
	usr/src/lib/libcurses/screen/tparm.c
	usr/src/lib/libcurses/screen/waddch.c
	usr/src/lib/libcurses/screen/wnoutref.c
	usr/src/lib/libcurses/screen/wrefresh.c

usr/src/lib/libcurses/screen/termcap.c (Diff revision 1)
Show all issues
```
This file should not be here.
```
1. tsoome Feb. 15, 2017, 7:32 p.m.
  yes, it is generated and I did miss the fact. removing.

Change Summary:

termcap.c is generated file, removing from the update.

Commit:

-	82218a7895f836c7d9b02e78affc5b01640d8ebb
+	ffdf2a257a9e167fb35b3268a7a5994a7a1b9adf

Diff:

Revision 3 (+115 -110)

Show changes

	usr/src/lib/libcurses/screen/termcap.ed
	usr/src/lib/libcurses/screen/tparm.c
	usr/src/lib/libcurses/screen/waddch.c
	usr/src/lib/libcurses/screen/wnoutref.c
	usr/src/lib/libcurses/screen/wrefresh.c

Ship it!

```
Ship It!
```
usr/src/lib/libcurses/screen/termcap.ed (Diff revision 3)
```
I would instead remove this line and unindent the while compound.
```
1. tsoome July 13, 2017, 8:42 p.m.
  done

usr/src/lib/libcurses/screen/tparm.c (Diff revision 3)

onrow is not referenced in a case setjmp() returns nonzero. Seems like a compiler bug.

tsoome July 13, 2017, 8:42 p.m.

Yep, but also do not want to start inserting "random" suppressions.

usr/src/lib/libcurses/screen/wnoutref.c (Diff revision 3)
```
s/lo+1/lo + 1/ ?
```
1. tsoome July 13, 2017, 8:42 p.m.
  done

Is there anything in these changes that would affect functionality?
If not, I'd just turn off the error. This is legacy code...

Change Summary:

Few simple suggestions from Marcel.

Commit:

-	ffdf2a257a9e167fb35b3268a7a5994a7a1b9adf
+	2d1b49e499d9376e2770a166bdfbcb131740a913

Diff:

Revision 4 (+123 -118)

Show changes

	usr/src/lib/libcurses/screen/termcap.ed
	usr/src/lib/libcurses/screen/tparm.c
	usr/src/lib/libcurses/screen/waddch.c
	usr/src/lib/libcurses/screen/wnoutref.c
	usr/src/lib/libcurses/screen/wrefresh.c

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

7875 libcurses: multiple misleading-indentation errors

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)