8192 in.ndpd: misleading-indentation
Review Request #487 - Created May 10, 2017 and submitted
Information | |
---|---|
Toomas Soome | |
illumos-gate | |
8192 | |
aea4d8f... | |
Reviewers | |
general | |
main.c:1870:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation] if (pr->pr_state & PR_AUTO) ^~ main.c:1872:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' prefix_delete(pr); ^~~~~~~~~~~~~ cc1: all warnings being treated as errors
Ship It!
-
usr/src/cmd/cmd-inet/usr.lib/in.ndpd/main.c (Diff revision 1) -
How did you determine that this should always be done. I'm having trouble determining if we're only supposed to be deleting all the prefixes regardless of if that was supposed to be bracketed on the PR_AUTO flag. It may be worth reaching out to Seb about that.
Ship It!
Ship It!