8198 acct: misleading-indentation
Review Request #493 - Created May 10, 2017 and submitted
| Information | |
|---|---|
| Toomas Soome | |
| illumos-gate | |
| 8198 | |
| 339464f... | |
| Reviewers | |
| general | |
devtolin.c: In function 'devtolin':
devtolin.c:106:4: error: this 'else' clause does not guard... [-Werror=misleading-indentation]
} else
^~~~
devtolin.c:115:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
return("?");
^~~~~~
cc1: all warnings being treated as errors
Review request changed
Change Summary:
cstyle cleanup.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+65 -46) |
-
usr/src/cmd/acct/lib/devtolin.c (Diff revision 2) -
Parens are not needed here.
-
usr/src/cmd/acct/lib/devtolin.c (Diff revision 2) -
Since you moved (okay, it was never there, but still) the
return ("?");line out of the else arm, then this line could be removed to save one level of indentation for the followingif. -
usr/src/cmd/acct/lib/devtolin.c (Diff revision 2) -
The typecast is not needed here.
Ship It!
Thanks for the clean up here. The else if bracketing was terrible.