8207 localedef links against libraries outside of proto area

Review Request #498 - Created May 12, 2017 and updated

Information
Andrew Stormont
illumos-gate
8207
08d1a84...
Reviewers
general

The localdef Makefile overrides LDLIBS which happens to include the -L flags which point the linker to libraries in the proto area.

I build illumos with -zassert-deflib. Without this diff the build fails due to libavl and libgen being pulled in from the default directories.

Andrew Stormont
Andrew Stormont
Andrew Stormont
Yuri Pankov
Alexander Pyhalov
Andrew Stormont
Review request changed

Description:

~  

I build illumos with -zassert-deflib. Without this diff the build fails due to libavl and libgen being pulled in from the default directories.

  ~

The localdef Makefile overrides LDLIBS which happens to include the -L flags which point the linker to libraries in the proto area.

Testing Done:

  +

I build illumos with -zassert-deflib. Without this diff the build fails due to libavl and libgen being pulled in from the default directories.

Rich Lowe
Ship It!
  1. I wanted to comment on that too, dammit reviewboard.

    Andy, any chance of you getting your assert-deflib changes in too? Robert (and me, to a much lesser degree) made similar changes ages ago, but something or other was screwing them up. If you have them working, it'd be fantastic to get them in.

  2. Indeed (I did a bit of this too, don't remember why I dropped it).

  3. I'm more than happy to get the assert-deflib upstreamed. I will have to add an option to turn them off, otherwise the majority of illumos folks wont be able to build anymore. Joyent probably being the only exception.

  4. For what it's worth, the way I was approaching this was to basically set the defaults to what they are in stock illumos-gate on OI/Omni and then undo those exceptions for libraries in illumos-joyent.

Garrett D'Amore
Ship It!
Yuri Pankov

looks like this is already integrated?

Loading...