8223 libshell: misleading-indentation

Review Request #510 - Created May 13, 2017 and updated

Information
Toomas Soome
illumos-gate
8223
9fd82c6...
Reviewers
general
../common/sh/nvdisc.c: In function 'nv_clone':
../common/sh/nvdisc.c:916:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if(mp->nvflag == flag)
  ^~
../common/sh/nvdisc.c:918:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   if(nv_isattr(np,NV_EXPORT))
   ^~
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
Igor Kozhukhov

   
usr/src/lib/libshell/common/sh/nvdisc.c (Diff revision 1)
 
 

have you checked logic - not just build it?
are you sure about additional 'if' should be there?

  1. based on relatively quick search around, and how they set the flag in code above (if statement from 898), I think the indentation is just an mistake. At least for now I do not have any reason to believe otherwise.

Robert Mustacchi
Ship It!
Loading...