8224 libshell: operation on '_Fcin.fcptr' may be undefined

Review Request #511 - Created May 13, 2017 and updated

Information
Toomas Soome
illumos-gate
8224
69decbd...
Reviewers
general
../common/sh/lex.c: In function 'sh_lex':
../common/include/fcin.h:49:39: error: operation on '_Fcin.fcptr' may be undefined [-Werror=sequence-point]
 #define fcseek(n) ((char*)(_Fcin.fcptr+=(n)))
                                       ^
../common/sh/lex.c:1089:7: note: in expansion of macro 'fcseek'
       fcseek(state-(fcseek(0)));
       ^~~~~~
cc1: all warnings being treated as errors

  
Marcel Telka

   
usr/src/lib/libshell/common/sh/lex.c (Diff revision 1)
 
 

Why is fcseek(state) not enough here?

  1. Ha, the above is obviously not enough. Please ignore.

Marcel Telka
Ship It!
Robert Mustacchi

It may help to add a few line analysis to the ticket for this.

  1. done.

Loading...