8229 ixgbe: misleading-indentation
Review Request #513 - Created May 15, 2017 and submitted
../../common/io/ixgbe/ixgbe_main.c:3001:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation] if ((i & 3) == 3) ^~ ../../common/io/ixgbe/ixgbe_main.c:3012:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' reta = 0; ^~~~ cc1: all warnings being treated as errors
While we're here can we put parens around the if statement, given that it's a large multi-line bit and it feels like we're one wrong thing away from this detecting what we mean to.
I'm not sure this is correct. This code looks like it's trying to group every three entries together, not clobber it. Otherwise this loop is pointless. Can you add some analysis?