8232 pcmcia: misleading-indentation

Review Request #515 - Created May 15, 2017 and updated

Information
Toomas Soome
illumos-gate
8232
35d7c16...
Reviewers
general
../../common/pcmcia/nexus/pcmcia.c: In function 'pcmcia_intr_disable_isr':
../../common/pcmcia/nexus/pcmcia.c:5428:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if (intr->handler_id != (uint32_t)(uintptr_t)rdip)
    ^~
../../common/pcmcia/nexus/pcmcia.c:5434:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
     ispecp = (struct intrspec *)&sockp->ls_intrspec;
     ^~~~~~
cc1: all warnings being treated as errors

  

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
I think this makes sense to move. It seems to me that getting the only handler versus the rdip is ... Robert Mustacchi Robert Mustacchi
Toomas Soome
Review request changed

Change Summary:

cstyle update.

Commit:

-7b2ec42246c5d2c93a7ff6121df1daa679d79a49
+35d7c16774ea25af14389bf10b97ddbf7d06fca7

Diff:

Revision 2 (+8 -8)

Show changes

Robert Mustacchi

   
I think this makes sense to move. It seems to me that  getting the only handler versus the rdip is assignment. What are your thoughts on this?
Loading...