8246 snoop(1m) clobbers status for the NFSv4 SETATTR operation
Review Request #521 — Created May 17, 2017 and submitted — Latest diff uploaded
Information | |
---|---|
marcel | |
illumos-gate | |
master | |
8246 | |
dd8f718... | |
Reviewers | |
general | |
This fixes the snoop(1m) output for the NFSv4 SETATTR operation where the returned status was not printed, even the code to do that was already there.
Without the fix: $ /usr/sbin/snoop -ta -r -i nfs4_setattr.cap 1 16:27:54.69663 10.0.2.15 -> 10.0.0.7 NFS C 4 (setattr ) PUTFH FH=9294 SETATTR ST=SPC0 GETATTR 10011a b0a23a 2 16:27:54.69668 10.0.0.7 -> 10.0.2.15 TCP D=1018 S=2049 Ack=3747778077 Seq=2732201278 Len=0 Win=65535 3 16:27:54.77984 10.0.0.7 -> 10.0.2.15 NFS R 4 (setattr ) NFS4_OK PUTFH NFS4_OK SETATTR 0 410000 GETATTR NFS4_OK $ With the fix: $ $ROOT/usr/sbin/snoop -ta -r -i nfs4_setattr.cap 1 16:27:54.69663 10.0.2.15 -> 10.0.0.7 NFS C 4 (setattr ) PUTFH FH=9294 SETATTR ST=SPC0 GETATTR 10011a b0a23a 2 16:27:54.69668 10.0.0.7 -> 10.0.2.15 TCP D=1018 S=2049 Ack=3747778077 Seq=2732201278 Len=0 Win=65535 3 16:27:54.77984 10.0.0.7 -> 10.0.2.15 NFS R 4 (setattr ) NFS4_OK PUTFH NFS4_OK SETATTR NFS4_OK 0 410000 GETATTR NFS4_OK $