8685 uts and mdb: do not build 32bit kernel

Review Request #630 - Created July 19, 2017 and updated

Information
Toomas Soome
illumos-gate
8685
629
0d5143f...
Reviewers
general

8685 uts and mdb: do not build 32bit kernel


  

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Toomas Soome
Yuri Pankov
Hans Rosenfeld
Dan McDonald
Dan McDonald
Toomas Soome
Toomas Soome
Dan McDonald
Toomas Soome
Review request changed

Change Summary:

32-bit libike.so.1 is needed for ikecert(1M), restore it.

Commit:

-1f1e6144fd381bda1e54f8309c40281e209168ca
+0d5143f29877c70be13c8424f17d8dcc10cd6342

Diff:

Revision 4 (+97 -4526)

Show changes

Andrew Stormont

FYI the debug version of the 32-bit kernel doesn't boot anymore. We hit an assert in vn_create_cache() because the size of vnode_t grew and VNODE_ALIGN_LOG2/VNODE_ALIGN need adjusting. If you fix this you end up hitting another assert in trap() and I have no idea where to begin with that. I think the sooner we can cut this stuff out the better.

Jerry Jelinek

I am in the process of pulling this patch into our smartos tree to build/test it. I haven't reviewed all of the files, but we had a conflict in usr/src/uts/intel/Makefile.intel and while resolving it I noticed quite a lot of 32-bit related entries and comments still in this file that have not been cleaned up. This is just an observation. I am not clear what the intention of the current change is supposed to be and if this stuff was missed or intentionally left.

  1. Oh, thanks. If you can provide the list, I can make update - I am sure there are many bits I have missed, so the more eyes the better:)

    One concern is that while we do have 32-bit userland, we want to be sure we do not break it - hence we need to provide 32-bit mdb for example. But the idea is to disable build of 32-bit kernel and modules, and clean up what we have spotted. The obvious issue is that once we stop building 32-bit kernel, we can only find the 32-bit related entries by visual inspection and therefore the cleanup will take more updates:)

Yuri Pankov
Ship It!
Peter Tribble

Tested by building and installing a Tribblix ISO from a copy of the gate with this patch applied, which worked without any errors that I've been able to detect so far.

Hans Rosenfeld
Ship It!
Andrew Stormont

No issues running with these changes.

  1. Thanks, I did file RTI yesterday evening, but I'll post an note for advocates:)

Jerry Jelinek

I'm happy with the current changes, since we know there is a lot of cleanup left to do.

Loading...