Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #639 -
Created Aug. 5, 2017 and submitted
Aug. 7, 2017, 2:35 p.m.
Initialize 'instance' right after entering the mutex.
i'd like do not drop instabce number in this message - it is useful with debug xen pv guests where you have to know instance number like at line 675
I'm not touching the line 675, you'll still have the instance number in the messages when there's real issue.
I've updated the fix to conditionally print the error message, please check if you like it better.
why not just init it to 0?
no need extra prints - print with0 will be enough i think
Won't that be a lie if that sanity check doesn't pass? I thought you do care about the instance number in that message.
Or yet another update, as we are entering the mutex, we assume the instance is initialized, so just move the assignment right after entering the mutex.
Revision 2 (+9 -3)
initialize instance right after entering the mutex
Revision 3 (+6 -2)
Simply don't use the instance when printing the debug output at the end of the function -- we don't use the instance number at the start as well.