2832 libsocket should go the way of libpthread

Review Request #649 - Created Aug. 14, 2017 and discarded

Information
Yuri Pankov
illumos-gate
master
2832
Reviewers
general

Make libsocket a filter library, moving its symbols to libc and libnsl.

I've checked the FreeBSD and Linux to see if they export these symbols in libc, and decided on that.

There's another problem here -- even if symbol should be in libc, it could be so tightly tied to libnsl interfaces that it's much easier (for the moment) to have it in libnsl and simply set a filter in libc.

This review only includes the lib/libc, lib/nsl, libsocket, and libxnet changes for easier reviewing -- there are a lot of other changes through the gate Makefiles to remove -lsocket, and, where it's not needed, -lnsl.

  • build
  • boot
  • compiling some of the external packages to see if they find all symbols they need in libc

Issues

  • 4
  • 0
  • 4
  • 8
Description From Last Updated
Deal with whatever this signifies Rich Lowe Rich Lowe
This is a shame Rich Lowe Rich Lowe
Either remove it, or remove the XXX comment. Rich Lowe Rich Lowe
Why remove the types, and the error checking they provide? Rich Lowe Rich Lowe
C Fraire
Yuri Pankov
Review request changed

Status: Discarded

Rich Lowe

   
usr/src/lib/libnsl/common/mapfile-vers (Diff revision 2)
 
 

Deal with whatever this signifies

usr/src/lib/libnsl/common/mapfile-vers (Diff revision 2)
 
 

This is a shame

usr/src/lib/libnsl/nss/gethostent.c (Diff revision 2)
 
 

I'm not certain removing this will do the right thing, but I have nothing concrete, just worries.

usr/src/lib/libc/port/inet/socket.c (Diff revision 2)
 
 

Either remove it, or remove the XXX comment.

usr/src/lib/libc/port/inet/socketpair.c (Diff revision 2)
 
 

Why remove the types, and the error checking they provide?

Loading...