Change Summary:
cstyle cleanup
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+138 -128) |
cstyle cleanup
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+138 -128) |
also need to adjust the memtop, as copyin/copyout/readin depend on it.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+143 -128) |
usr/src/boot/sys/boot/i386/libi386/biosmem.c (Diff revision 1) |
---|
So, the bug comments have some important information here about why we're looking for the last bit to make space for others. Would you mind updating the comment to make that clearer?
Comment about heap setup updated.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+144 -128) |
usr/src/boot/sys/boot/i386/libi386/biosmem.c (Diff revision 4) |
---|
Hello. Maybe clarify "... set heap to use highest HEAP_MIN bytes below 4GB" instead of "just below". E.g., on a test VM where I assign only 1GB it would not be "just below 4GB".
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+144 -128) |
remove extra smbios.h include
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+144 -129) |
(Hmmm, a little RB bug in showing the 5-6 diff for "remove extra smbios.h"? Please chime in to Josh Clulow [as Robert M has done] to join in the request for an RB upgrade!).
LGTM
Really tiny update to keep FBSD comment in sync...
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+144 -129) |