- Download Diff

Information
Submitter:	Toomas Soome
Repository:	illumos-gate
Branch:
Bugs:	8717
Depends On:
Commit:	be47c12...
Reviewers
Groups:	general
People:

Description

ns_files.c: In function 'call_read_execout':
ns_files.c:684:37: error: parameter 'lp' set but not used [-Werror=unused-but-set-parameter]
 call_read_execout(char *key, char **lp, char *fname, char *line,
                                     ^~

autod_nfs.c: In function 'read_default_nfs':
autod_nfs.c:3985:16: error: variable 'lastread' set but not used [-Werror=unused-but-set-variable]
  static time_t lastread = 0;
                ^~~~~~~~

cc1: all warnings being treated as errors

Testing Done

did add entry into auto_master:
/test auto_exec

and the script has:
root@beastie:/test# more /etc/auto_exec

!/bin/sh

echo "localhost:/export/&"
exit 0

and verified the mounts are done - so the exec maps are still working as expected.

Issues

0
1
0
All Issues: 1

Description	From	Last Updated
So why does the compiler complain about this? This feels really weird to me. For parameters, isn't it a common ...	Robert Mustacchi	Oct. 14, 2017, 10:49 a.m.

Ship it!

LGTM

Ship it!

Ship It!

usr/src/cmd/fs.d/autofs/ns_files.c (Diff revision 1)

Show all issues

So why does the compiler complain about this? This feels really weird to me. For parameters, isn't it a common pattern to have output data which will be set and not read?

Toomas Soome Oct. 14, 2017, 10:51 a.m.

Indeed, we can clear it more than just simple silencing. If anything, the assignment should use *lp, but in fact, that argument is not needed at all, since the caller does not need that pointer to be returned.

Change Summary:

a bit more cleanup, we really do not need the lp.

Commit:

-	f4eeb97b1e2b2ff356f27b95dbb7266adf43fa15
+	285af5ba0adc1a18dd3ccbc30066661bf0a206f2

Diff:

Revision 2 (+4 -12)

Show changes

	usr/src/cmd/fs.d/autofs/autod_nfs.c
	usr/src/cmd/fs.d/autofs/ns_files.c

Change Summary:

call_read_execout is declared static. make it so.

Commit:

-	285af5ba0adc1a18dd3ccbc30066661bf0a206f2
+	be47c12a8f6f4a21b9fb44b4553c74ac92ade940

Diff:

Revision 3 (+5 -13)

Show changes

	usr/src/cmd/fs.d/autofs/autod_nfs.c
	usr/src/cmd/fs.d/autofs/ns_files.c

Ship it!

Ship It!

Ship it!

still LGTM

Change Summary:

updated the testing.

Testing Done:

	+	did add entry into auto_master:
	+	/test auto_exec
	+
	+	and the script has:
	+	root@beastie:/test# more /etc/auto_exec
	+
	+	!/bin/sh
	+
	+	echo "localhost:/export/&"
	+	exit 0
	+
	+	and verified the mounts are done - so the exec maps are still working as expected.

Ship it!

Ship It!

You have a pending review.

Review Board 2.5.16

8717 autofs: parameter/variable set but not used

!/bin/sh

Screenshots

Files

Issues

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Testing Done:

!/bin/sh

Status: Closed (submitted)