8733 cxgbe: variable 'execute' set but not used

Review Request #684 — Created Oct. 27, 2017 and submitted Feb. 7, 2018, 8:49 a.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	8733
Depends On:
Commit:	cbc2317...
Reviewers
Groups:	general
People:

Description

../../../common/io/cxgbe/common/t4_hw.c:351:6: error: variable 'execute' set but not used [-Werror=unused-but-set-variable]
  u16 execute = 0;
      ^~~~~~~
cc1: all warnings being treated as errors

Testing Done

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
Is this warning actually that the 0 is unused, since `execute' is reassigned later before its use as a function ...	seeemef@mac.com	Oct. 27, 2017, 3:06 p.m.

usr/src/uts/common/io/cxgbe/common/t4_hw.c (Diff revision 1)

Show all issues

Is this warning actually that the 0 is unused, since `execute' is reassigned later before its use as a function arg? Would it be more terse to just remove the assignment?

danmcd Oct. 27, 2017, 2:28 p.m.

Chris is right.  Remove the "= 0" and you should be good (and with less invasive changes).

tsoome Oct. 27, 2017, 2:56 p.m.

nop. with debug mode:

../../../common/io/cxgbe/common/t4_hw.c: In function 't4_wr_mbox_meat_timeout':

../../../common/io/cxgbe/common/t4_hw.c:351:6: error: variable 'execute' set but not used [-Werror=unused-but-set-variable]

  u16 execute;

      ^_~_~
And yea, well, we do not need to move out assignments; at the time I did want to check if it will improve the readability.