usr/src/uts/common/io/cxgbe/common/t4_hw.c (Diff revision 1)

Show all issues

Is this warning actually that the 0 is unused, since `execute' is reassigned later before its use as a function arg? Would it be more terse to just remove the assignment?

1. 

   Dan McDonald Oct. 27, 2017, 8:28 a.m.

   Chris is right.  Remove the "= 0" and you should be good (and with less invasive changes).

2. 

   Toomas Soome Oct. 27, 2017, 8:56 a.m.

   nop. with debug mode:
   
   ../../../common/io/cxgbe/common/t4_hw.c: In function 't4_wr_mbox_meat_timeout':
   
   ../../../common/io/cxgbe/common/t4_hw.c:351:6: error: variable 'execute' set but not used [-Werror=unused-but-set-variable]
   
     u16 execute;
   
         ^~~~~~~
   And yea, well, we do not need to move out assignments; at the time I did want to check if it will improve the readability.

3. 

   Dan McDonald Oct. 27, 2017, 9:06 a.m.

   Further down there's an "execute = i + 1" in a for loop.  That's the set.  Why isn't it used, though?!

4. 

   Jason King Oct. 27, 2017, 5:25 p.m.

   It's used by the CH_MSG macro, which elides the statement in non-debug builds, and generates the warning.

OK, I see. LGTM

Ship It!

Ship It!

-1.
Replace "execute" with "i + 1".  That's what we did.

Ship It!

Ship It!

Ship It!

Ship It!