8737 vi: variable set but not used

Review Request #688 — Created Oct. 27, 2017 and submitted Nov. 10, 2017, 6:13 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	8737
Depends On:
Commit:	2392b3b...
Reviewers
Groups:	general
People:

Description

ex_vmain.c: In function 'vmain':
ex_vmain.c:620:19: error: variable 'tmp1' set but not used [-Werror=unused-but-set-variable]
     unsigned char tmp1;
                   ^~~~
ex_vmain.c:617:19: error: variable 'n' set but not used [-Werror=unused-but-set-variable]
     int tmp, len, n;
                   ^
cc1: all warnings being treated as errors

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
For `n' I searched but truly did not find any usage past its assignment. Mightn't it be removed along with ...	seeemef@mac.com	Oct. 28, 2017, 10:07 a.m.

usr/src/cmd/vi/port/ex_vmain.c (Diff revision 1)

Show all issues

For `n' I searched but truly did not find any usage past its assignment. Mightn't it be removed along with line 636?

tsoome Oct. 28, 2017, 10:07 a.m.
```
yep. thanks!
```

Yes, you should just remove the declaration of the variable n' along with the line that sets it.n' is truely unused. As well, the variable tmp1' is used only in the PRESUNEUC conditional case, although it's set just before the conditional. If you move the linetmp1 = mbuf[tmp_1]' down one line, so that it's just before where it is used, you can also move the declaration into the correct case. With those changes, you won't need to mark any variables as possibly unused.