8760 troff: variable 'type' set but not used

Reviews
Diff

- Download Diff

Information
Submitter:	Toomas Soome
Repository:	illumos-gate
Branch:
Bugs:	8760
Depends On:
Commit:	13c81fc...
Reviewers
Groups:	general
People:

Description

../n9.c: In function 'setdraw':

../n9.c:314:44: error: variable 'type' set but not used [-Werror=unused-but-set-variable]

  int i, j, k, dx[NPAIR], dy[NPAIR], delim, type;

                                            ^~~~

cc1: all warnings being treated as errors

Testing Done

Hi. The description also describes n6.c as affected, but it is not in the diff.

Toomas Soome Nov. 5, 2017, 10 a.m.

aye, that one got fixed in "8485 Remove set but unused variables in usr/src/cmd".

usr/src/cmd/troff/n9.c (Diff revision 1)

Maybe we should cast this to (void) rather than assign it to a variable, but leave a comment saying that this is important for making sure that we properly consume the input?

Toomas Soome Nov. 5, 2017, 10:28 a.m.

I was considering it, but below is the code segment using type == DRAWELLIPSE and I would rather avoid going too invasive with this patch.

Robert Mustacchi Nov. 5, 2017, 6:13 p.m.

Ah, I missed that. I guess we don't define NROFF?

Toomas Soome Nov. 13, 2017, 11:22 a.m.

Actually we do, but only in nroff.d directory - the troff.d case does not define it.

Summary:

-	troff: variable 'type' set but not used
+	8760 troff: variable 'type' set but not used

Description:

-		n6.c: In function 'setht':
-		n6.c:204:6: error: variable 'n' set but not used [-Werror=unused-but-set-variable]
-		int n;
-		^
-
		../n9.c: In function 'setdraw':
		../n9.c:314:44: error: variable 'type' set but not used [-Werror=unused-but-set-variable]
		int i, j, k, dx[NPAIR], dy[NPAIR], delim, type;
		^~~~
		cc1: all warnings being treated as errors

Ship it!

LGTM

Ship it!

Ship It!

Will we now get an error if we don't define NROFF, which will cause 'type' to be used?
The "problem" is the warning there is not really an error.

(FWIW, Heirloom's troff added type DRAWPOLYGON in addition to type DRAWELLIPSE, plus type DRAWTHICKNESS.)

-- John

Toomas Soome Jan. 18, 2018, 6:54 p.m.

Technically it is warning, just that we do interpret all warnings as errors. And indeed, in case of nroff, we wont get that warning. However, since we do know this is an problem, we tell compiler to switch the warning off for this variable.

Ship it!

Ship It!

You have a pending review.

Review Board 2.5.16

Screenshots

Files

Summary:

Description:

Status: Closed (submitted)