8769 mv: variable 'rc' set but not used

Review Request #709 — Created Nov. 6, 2017 and submitted

tsoome
illumos-gate
8769
81f1e92...
general
mv.c: In function 'chg_time':
mv.c:1357:6: error: variable 'rc' set but not used [-Werror=unused-but-set-variable]
  int rc;
      ^~
cc1: all warnings being treated as errors


andy_js
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. 
      
  2. usr/src/cmd/mv/mv.c (Diff revision 1)
     
     

    Hi, might only the left-hand sides [rc=, (void)] be conditionally defined without duplicating the function call?

    1. I do not think it will make anything better, I would rather look how to get rid of that #ifdef XPG4, but that should be done in separate patch.

  3. 
      
jgmills
  1. This change looks good to me.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...