8776 krb5kdc: right-hand operand of comma expression has no effect

Review Request #715 — Created Nov. 6, 2017 and submitted

tsoome
illumos-gate
8776
2bfac61...
general
network.c: In function 'delete_fd':
network.c:218:37: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
   (set.data[idx] = set.data[--set.n], 0)
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
network.c:342:6: note: in expansion of macro 'DEL'
      DEL(connections, i);
      ^~~
network.c: In function 'closedown_network':
network.c:218:37: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
   (set.data[idx] = set.data[--set.n], 0)
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
network.c:1136:2: note: in expansion of macro 'DEL'
  DEL (connections, i);
  ^~~
cc1: all warnings being treated as errors


seeemef@mac.com
  1. LGTM

  2. 
      
hans
  1. Ship It!
  2. 
      
jgmills
  1. I agree that this change is the correct solution.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...