8828 udapl: value computed is not used

Review Request #755 - Created Nov. 20, 2017 and submitted

Information
Toomas Soome
illumos-gate
8828
1f9eefe...
Reviewers
general
In file included from /code/illumos-gate/usr/src/lib/udapl/udapl_tavor/include/dapl.h:53:0,
                 from /code/illumos-gate/usr/src/lib/udapl/udapl_tavor/include/dapl_evd_util.h:48,
                 from ../common/dapl_evd_util.c:42:
../common/dapl_evd_util.c: In function 'dapli_evd_event_alloc':
/code/illumos-gate/usr/src/lib/udapl/udapl_tavor/include/dapl_osd.h:125:43: error: value computed is not used [-Werror=unused-value]
     (atomic_add_32_nv((uint32_t *)(v), 1) - 1))
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../common/dapl_evd_util.c:312:3: note: in expansion of macro 'dapl_os_atomic_inc'
   dapl_os_atomic_inc(&cno_ptr->cno_ref_count);
   ^~~~~~~~~~~~~~~~~~
../common/dapl_evd_util.c: In function 'dapls_evd_dealloc':
/code/illumos-gate/usr/src/lib/udapl/udapl_tavor/include/dapl_osd.h:136:44: error: value computed is not used [-Werror=unused-value]
     (atomic_add_32_nv((uint32_t *)(v), -1) + 1))
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../common/dapl_evd_util.c:376:3: note: in expansion of macro 'dapl_os_atomic_dec'
   dapl_os_atomic_dec(&evd_ptr->cno_ptr->cno_ref_count);
   ^~~~~~~~~~~~~~~~~~
../common/dapl_evd_util.c: In function 'dapli_evd_cqe_to_event':
/code/illumos-gate/usr/src/lib/udapl/udapl_tavor/include/dapl_osd.h:136:44: error: value computed is not used [-Werror=unused-value]
     (atomic_add_32_nv((uint32_t *)(v), -1) + 1))
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../common/dapl_evd_util.c:1005:5: note: in expansion of macro 'dapl_os_atomic_dec'
     dapl_os_atomic_dec(&srq_ptr->recv_count);
     ^~~~~~~~~~~~~~~~~~
/code/illumos-gate/usr/src/lib/udapl/udapl_tavor/include/dapl_osd.h:136:44: error: value computed is not used [-Werror=unused-value]
     (atomic_add_32_nv((uint32_t *)(v), -1) + 1))
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../common/dapl_evd_util.c:1008:5: note: in expansion of macro 'dapl_os_atomic_dec'
     dapl_os_atomic_dec(&ep_ptr->recv_count);
     ^~~~~~~~~~~~~~~~~~
/code/illumos-gate/usr/src/lib/udapl/udapl_tavor/include/dapl_osd.h:136:44: error: value computed is not used [-Werror=unused-value]
     (atomic_add_32_nv((uint32_t *)(v), -1) + 1))
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../common/dapl_evd_util.c:1012:4: note: in expansion of macro 'dapl_os_atomic_dec'
    dapl_os_atomic_dec(&ep_ptr->req_count);
    ^~~~~~~~~~~~~~~~~~
/code/illumos-gate/usr/src/lib/udapl/udapl_tavor/include/dapl_osd.h:136:44: error: value computed is not used [-Werror=unused-value]
     (atomic_add_32_nv((uint32_t *)(v), -1) + 1))
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../common/dapl_evd_util.c:1147:3: note: in expansion of macro 'dapl_os_atomic_dec'
   dapl_os_atomic_dec(&ep_ptr->req_count);
   ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  
Yuri Pankov
Gary Mills
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...