6080 libbe should support installboot
Review Request #77 — Created July 23, 2015 and submitted
| Information | |
|---|---|
| tsoome | |
| illumos-gate | |
| 6080 | |
| 78 | |
| 809de41... | |
| Reviewers | |
| general | |
6080 libbe should support installboot
dmake lint/git-pbchk, functional test in loader project. Will add actual SPARC results once I get chance to access one.
Tested x86 grub; created test BE and incremented manually its cap version by 1 (to 26). be activate with test be and old be did correctly follow the version check and updated the bootloader+cap file when needed - verified with capability file check and truss traces.
for SPARC test I did port this code to dilos (functional logic is the same) and it does show correct behaviour:
igork: root@srv209:~# truss -f -o truss.txt beadm activate -v dilos-test
igork: ==be_do_installgrub: physpath=/pci@1d,700000/scsi@4/sd@0,0:a
igork: ==physpath:/pci@1d,700000/scsi@4/sd@0,0:a
igork: ==be_do_installboot: /dev/dsk/c1t0d0s0, dev_link:c1t0d0s0
igork: ==be_do_installboot: wholedisk=0
igork: ==be_do_installboot_helper: cmd:
igork: /usr/sbin/installboot -F zfs /tmp/.be.3uaSDa/usr/platform/SUNW,Sun-Blade-2500/lib/fs/zfs/bootblk /dev/rdsk/c1t0d0s0so even as this sparc test is not 100% exactly the same diff as included here, it does show the logic itself is ok:)
richlowe
Change Summary:
be_do_copy_grub_cap() missed the BE dataset mount and therefore used (null) prefix for BE cap file.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+312 -160) |
Change Summary:
updated testing done report.
Testing Done: |
|
|---|
Change Summary:
whitespace errors fixed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+312 -160) |
Change Summary:
added test results from dilos sparc.
Testing Done: |
|
|---|
Change Summary:
include boot_utils.h and use BC_* codes to check return codes from installboot/installgrub.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+317 -161) |
-
-
usr/src/lib/libbe/common/be_activate.c (Diff revision 4) doesn't the comment at line 1140 suggest that you're conflating "does not have grub" and "is sparc" here?