6085 export libbe installboot function

Review Request #78 — Created July 26, 2015 and submitted Sept. 16, 2015, 9:40 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	6085
Depends On:	77
Blocks:	88, 79
Reviewers
Groups:	general
People:

Description

Testing Done

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
Having a define for the zero case is a bit strange. Usually, I see a define for each bit but ...	jeffpc	Aug. 31, 2015, 5:03 p.m.

Status: Discarded

Status: Re-opened

Summary:

-	6080 libbe should support installboot
+	6085 export libbe installboot function

Bugs:

+	6085

Depends On:

+	~~77 - 6080 libbe should support installboot~~

Diff:

Revision 1 (+152 -24)

	usr/src/lib/libbe/common/be_activate.c
	usr/src/lib/libbe/common/libbe.h
	usr/src/lib/libbe/common/mapfile-vers

Change Summary:

fixed comment for be_installboot; removed installboot case from i386.

Diff:

Revision 2 (+146 -21)

Show changes

	usr/src/lib/libbe/common/be_activate.c
	usr/src/lib/libbe/common/libbe.h
	usr/src/lib/libbe/common/mapfile-vers

usr/src/lib/libbe/common/libbe.h (Diff revision 2)

Show all issues

Having a define for the zero case is a bit strange. Usually, I see a define for each bit but the zero (no flags) case is just open coded.

tsoome Aug. 31, 2015, 5 p.m.

I did decide to keep the same style as it was used for MOUNT/UMOUNT/DESTROY flags; also the FLAG_NULL is actually used also in similar contexts, to check/set default flags while serviceing call from beadm (thats case with mount/umount/destroy) or bootadm in case of installboot. It certainly did felt a bit strange for me as well, but I would rather prefer to keep the overall consistency in this implementation.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

6085 export libbe installboot function

Status: Discarded

Status: Re-opened

Summary:

Bugs:

Depends On:

Diff:

Change Summary:

Diff:

Status: Closed (submitted)