6085 export libbe installboot function

Review Request #78 — Created July 26, 2015 and submitted

tsoome
illumos-gate
6085
77
88, 79
general

6085 export libbe installboot function



  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
tsoome
tsoome
tsoome
jeffpc
  1. 
      
  2. usr/src/lib/libbe/common/libbe.h (Diff revision 2)
     
     

    Having a define for the zero case is a bit strange. Usually, I see a define for each bit but the zero (no flags) case is just open coded.

    1. I did decide to keep the same style as it was used for MOUNT/UMOUNT/DESTROY flags; also the FLAG_NULL is actually used also in similar contexts, to check/set default flags while serviceing call from beadm (thats case with mount/umount/destroy) or bootadm in case of installboot. It certainly did felt a bit strange for me as well, but I would rather prefer to keep the overall consistency in this implementation.

  3. 
      
jeffpc
  1. Ship It!
  2. 
      
igork
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...