8905 loader: add skein/edonr support

Review Request #794 — Created Dec. 8, 2017 and submitted

tsoome
illumos-gate
8905
793
795
1f19f3c...
general
8905 loader: add skein/edonr support

enabled skein/edonr, create file and read it.

  • 0
  • 0
  • 3
  • 1
  • 4
Description From Last Updated
seeemef@mac.com
  1. LGTM

  2. 
      
rm
  1. 
      
  2. Maybe worth a commet saying why we need these?

  3. usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 1)
     
     
    Where do we check these kinds of things for overflow?
  4. Is this a copy of something we already have in the gate?

    1. Yes and no. The edonr/skein code was built before ABD, and since ABD is targeting issues in ARC, I'm not really convinced we should use it in loader zfs reader code. At least for now, I would keep the code separate even if it does mean some amount of duplication. But it really is not written in stone and we can change this at any point of time.

  5. usr/src/boot/sys/sys/debug.h (Diff revision 1)
     
     

    Are these copies of all of our existing headers?

  6. 
      
tsoome
seeemef@mac.com
  1. Ship It!
  2. 
      
tsoome
citrus
  1. Ship It!
  2. 
      
kmays
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...