6088 Unable to enable the nfs/server service when nothing is shared

Review Request #81 — Created July 27, 2015 and submitted

marcel
illumos-gate
6088
general

webrev: http://cr.illumos.org/~webrev/marcel/il-nfs-smf-enable/

NFS service cannot be enabled if no file systems are shared. This is inconsistent with SMB, and causes confusion. It works this way, because there is automatic nfs server starting implemented, so it is not expected one might want to enable the nfs/service by hand (but this expectation is strange).

The fix is changing usr/src/cmd/fs.d/nfs/svc/nfs-server to start both nfsd and mountd regardless the number of active shares.

I tested the various scenarios to make sure the nfs/server service is enabled
even there is nothing shared. I also make sure the auto_enable feature is
still working properly.

andy_js
  1. Ship It!
  2. 
      
tsoome
  1. wouldn't it better to have copyright dates in ascending order?:)

    1. No. Historically, they are usually in the descending order, for example: http://src.illumos.org/source/xref/illumos-gate/usr/src/cmd/bnu/anlwrk.c

      More details about the topic: http://www.listbox.com/member/archive/182179/2015/03/search/UmV2aWV3OiA0NTE4IGxvY2tk/sort/time_rev/page/1/entry/6:9/20150327125645:3DDBC62C-D4A2-11E4-914F-834A8C92F9B2/

  2. 
      
igork
  1. Ship It!
  2. 
      
relling
  1. Ship It!
  2. 
      
richlowe
  1. Ship It!
  2. 
      
marcel
Review request changed

Status: Closed (submitted)

Change Summary:

commit 50b1420592e389f7ad93528e20c703aff72dc15e
Author:     Marcel Telka <marcel.telka@nexenta.com>
AuthorDate: Thu Jul 9 22:09:37 2015 +0200
Commit:     Robert Mustacchi <rm@joyent.com>
CommitDate: Thu Jul 30 08:34:09 2015 -0700

    6088 Unable to enable the nfs/server service when nothing is shared
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Richard Elling <Richard.Elling@RichardElling.com>
    Reviewed by: Rich Lowe <richlowe@richlowe.net>
    Approved by: Robert Mustacchi <rm@joyent.com>

:100644 100644 b0c6d15... 1c7391b... M  usr/src/cmd/fs.d/nfs/svc/nfs-server
Loading...