6095 usr/src/tools/scripts/cstyle.pl errors with perl 5.22

Review Request #82 — Created Aug. 3, 2015 and submitted

tsoome
illumos-gate
6095
a639c42...
general
6095 usr/src/tools/scripts/cstyle.pl errors with perl 5.22

git-pbck does not complain about cstyle script.

andy_js
  1. Ship It!
  2. 
      
marcel
  1. Ship It!
  2. 
      
igork
  1. Ship It!
  2. 
      
risto3
  1. Ship It!
  2. 
      
tsoome
marcel
  1. Ship It!
  2. 
      
danmcd
  1. Dumb question --> has anyone tried this version on an older-perl distro (like OmniOS or SmartOS)?

    1. actually yes. altho those updates shouldn't even be version dependant:

      tsoome@dilos:~$ perl -v

      This is perl 5, version 16, subversion 3 (v5.16.3) built for i86pc-solaris-64

      clean file:

      tsoome@dilos:~$ perl ./cstyle.pl main.c
      tsoome@dilos:~$

      file with different errors:
      tsoome@dilos:~$ perl ./cstyle.pl main.c
      main.c: 2: improper block comment
      main.c: 116: space or tab at end of line
      main.c: 119: last line in file is blank

    2. Thank you!

    3. updated bad test for { :D

      tsoome@dilos:~$ perl ./cstyle.pl main.c
      main.c: 2: improper block comment
      main.c: 108: missing space before left brace
      main.c: 116: space or tab at end of line
      main.c: 119: last line in file is blank

  2. 
      
danmcd
  1. Just wanted to make sure it worked with older Perls.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...