diff: clean build warnings

Review Request #824 - Created Jan. 29, 2018 and updated

Information
Toomas Soome
illumos-gate
7541818...
Reviewers
general
diff: clean build warnings

  

Issues

  • 9
  • 0
  • 0
  • 9
Description From Last Updated
!= L'\0'? Yuri Pankov Yuri Pankov
!= L'\0'? Yuri Pankov Yuri Pankov
May be use {} for this branch as well? Yuri Pankov Yuri Pankov
This is one ugly formatted comment. Yuri Pankov Yuri Pankov
Don't really need this comment. Yuri Pankov Yuri Pankov
!= 0? Yuri Pankov Yuri Pankov
!= '\0'? Yuri Pankov Yuri Pankov
!= '\0'? Yuri Pankov Yuri Pankov
!= '\0'? Yuri Pankov Yuri Pankov
Yuri Pankov

   
usr/src/cmd/diff/diff.c (Diff revision 1)
 
 

!= L'\0'?

usr/src/cmd/diff/diff.c (Diff revision 1)
 
 

!= L'\0'?

usr/src/cmd/diff/diff.c (Diff revision 1)
 
 

May be use {} for this branch as well?

usr/src/cmd/diff/diff.c (Diff revision 1)
 
 

This is one ugly formatted comment.

usr/src/cmd/diff/diff.c (Diff revision 1)
 
 

That's.... ugly! :D

usr/src/cmd/diff/diff.c (Diff revision 1)
 
 

Don't really need this comment.

usr/src/cmd/diff/diff.c (Diff revision 1)
 
 

I wonder why not != 0 check here, do we really care about retval being greater than zero (as compared to being non-zero)?

usr/src/cmd/diff/diff.c (Diff revision 1)
 
 

!= 0?

usr/src/cmd/diff/diffh.c (Diff revision 1)
 
 

!= '\0'?

usr/src/cmd/diff/diffh.c (Diff revision 1)
 
 

!= '\0'?

usr/src/cmd/diff/diffh.c (Diff revision 1)
 
 

!= '\0'?

Loading...